Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2711473005: Rename CSSMatrixTransformComponent -> CSSMatrixComponent (Closed)

Created:
3 years, 10 months ago by nainar
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10, rjwright
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CSSMatrixTransformComponent -> CSSMatrixComponent This patch renames CSSMatrixTransformComponent to CSSMatrixComponent. This patch is needed due to a spec change. Change can be seen here: https://drafts.css-houdini.org/css-typed-om/#ref-for-cssmatrixcomponent-1 Pull request can be seen here: https://github.com/w3c/css-houdini-drafts/commit/f5c7cdc6e4aba08b5d43e3f4e0446e8b25032657 BUG= Review-Url: https://codereview.chromium.org/2711473005 Cr-Commit-Position: refs/heads/master@{#453152} Committed: https://chromium.googlesource.com/chromium/src/+/b609f8c9ef45ec9957da6fe591da61eb2cd50bfc

Patch Set 1 #

Total comments: 1

Patch Set 2 : Tried git mv this time around #

Patch Set 3 : Rename cssMatrixTransformComponent.html => cssMatrixComponent.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -481 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html View 1 2 3 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssMatrixTransformComponent.html View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssRotation.html View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssScale.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTransformValue.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h View 1 chunk +162 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.cpp View 2 chunks +25 lines, -30 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.h View 1 chunk +0 lines, -171 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPerspective.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSScale.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSkew.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (20 generated)
nainar
Renee, Can you take a first pass please? Also sorry for the odd diff due ...
3 years, 10 months ago (2017-02-21 23:08:19 UTC) #4
nainar
Renee, Tried using git mv this time around. Hope things look better. :)
3 years, 10 months ago (2017-02-22 03:26:20 UTC) #10
rjwright
Should also rename LayoutTests/typedcssom/cssMatrixTransformComponent.html LGTM
3 years, 10 months ago (2017-02-23 23:32:01 UTC) #14
nainar
Thanks for the catch! Change made. Eddy, PTAL? Thanks!
3 years, 10 months ago (2017-02-23 23:41:13 UTC) #17
meade_UTC10
rs lgtm
3 years, 9 months ago (2017-02-27 02:35:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711473005/40001
3 years, 9 months ago (2017-02-27 02:47:10 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 05:00:48 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b609f8c9ef45ec9957da6fe591da...

Powered by Google App Engine
This is Rietveld 408576698