Move task.describe descriptions to audit.define

Move task.describe descriptiosn to audit.define

Move the description of the task into the first argument
audit.define.  This is the first step at removing support for
task.describe.

The conversion was done using the gawk script:

/^ *audit.define\(/ {
  audit = $0
  next
}
/^ *task.describe\(.*\);/ {
  desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat);
  label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat)
  printf "%saudit.define({\n", label_pat[1]
  printf "%s  label: %s,\n", label_pat[1], label_pat[2]
  printf "%s  description: %s\n", label_pat[1], desc_pat[2]
  printf "%s},%s", label_pat[1], label_pat[3]
  next
}
{ print }

This script tries to indent things reasonably nicely, but doesn't
handle the case where the description is very long or where the indentation is different.

Also, not all files could be converted automatically because the
script is not smart enough.  These will be handled separately.

BUG=694659
TEST=none

Review-Url: https://codereview.chromium.org/2708953003
Cr-Commit-Position: refs/heads/master@{#453770}
Committed: https://chromium.googlesource.com/chromium/src/+/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc

[Raymond Toy, 2017-02-22 16:35:49]

Description was changed from

==========
Move task.describe descriptiosn to audit.define

Move the description of the task into the first argument
audit.define.  This is the first step at removing support for
task.describe.

The conversion was done using the gawk script:

/^ *audit.define\(/ {
  audit = $0
  next
}
/^ *task.describe\(.*\);/ {
  desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat);
  label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat)
  printf "%saudit.define({\n", label_pat[1]
  printf "%s  label: %s,\n", label_pat[1], label_pat[2]
  printf "%s  description: %s\n", label_pat[1], desc_pat[2]
  printf "%s},%s", label_pat[1], label_pat[3]
  next
}
{ print }

This script tries to indent things reasonably nicely, but doesn't
handle the case where the description is very long.

BUG=694659
TEST=none
==========

to

==========
Move task.describe descriptiosn to audit.define

Move the description of the task into the first argument
audit.define.  This is the first step at removing support for
task.describe.

The conversion was done using the gawk script:

/^ *audit.define\(/ {
  audit = $0
  next
}
/^ *task.describe\(.*\);/ {
  desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat);
  label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat)
  printf "%saudit.define({\n", label_pat[1]
  printf "%s  label: %s,\n", label_pat[1], label_pat[2]
  printf "%s  description: %s\n", label_pat[1], desc_pat[2]
  printf "%s},%s", label_pat[1], label_pat[3]
  next
}
{ print }

This script tries to indent things reasonably nicely, but doesn't
handle the case where the description is very long.

BUG=694659
TEST=none
==========

[Raymond Toy, 2017-02-22 16:36:28]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-22 16:36:29]

PTAL and let me know if this style for the conversion looks good.

[Raymond Toy, 2017-02-22 17:02:48]

Patchset #2 (id:20001) has been deleted

[Raymond Toy, 2017-02-22 17:50:49]

Description was changed from

==========
Move task.describe descriptiosn to audit.define

Move the description of the task into the first argument
audit.define.  This is the first step at removing support for
task.describe.

The conversion was done using the gawk script:

/^ *audit.define\(/ {
  audit = $0
  next
}
/^ *task.describe\(.*\);/ {
  desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat);
  label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat)
  printf "%saudit.define({\n", label_pat[1]
  printf "%s  label: %s,\n", label_pat[1], label_pat[2]
  printf "%s  description: %s\n", label_pat[1], desc_pat[2]
  printf "%s},%s", label_pat[1], label_pat[3]
  next
}
{ print }

This script tries to indent things reasonably nicely, but doesn't
handle the case where the description is very long.

BUG=694659
TEST=none
==========

to

==========
Move task.describe descriptiosn to audit.define

Move the description of the task into the first argument
audit.define.  This is the first step at removing support for
task.describe.

The conversion was done using the gawk script:

/^ *audit.define\(/ {
  audit = $0
  next
}
/^ *task.describe\(.*\);/ {
  desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat);
  label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat)
  printf "%saudit.define({\n", label_pat[1]
  printf "%s  label: %s,\n", label_pat[1], label_pat[2]
  printf "%s  description: %s\n", label_pat[1], desc_pat[2]
  printf "%s},%s", label_pat[1], label_pat[3]
  next
}
{ print }

This script tries to indent things reasonably nicely, but doesn't
handle the case where the description is very long or where the indentation is
different.

Also, not all files could be converted automatically because the
script is not smart enough.  These will be handled separately.

BUG=694659
TEST=none
==========

[Raymond Toy, 2017-02-22 17:52:42]

PTAL.  These files were the ones that the script could handle and I didn't edit
the results in any way, so that indentation and spacing may be incorrrect.

The files that weren't converted will be handled in a different CL.

[hongchan, 2017-02-22 17:59:13]

lgtm with nits. I don't mind fixing them manually.

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html
(right):

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html:73:
}, function (task, should) {        let tests = [];
Oops. The following line popped up to here.

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing.html
(right):

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing.html:35:
}, function (task, should) {  doTest(-1, true, should);
Same issue.

[Raymond Toy, 2017-02-22 19:34:09]

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html
(right):

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html:73:
}, function (task, should) {        let tests = [];
On 2017/02/22 17:59:13, hongchan wrote:
> Oops. The following line popped up to here.

Done.

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing.html
(right):

https://codereview.chromium.org/2708953003/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing.html:35:
}, function (task, should) {  doTest(-1, true, should);
On 2017/02/22 17:59:13, hongchan wrote:
> Same issue.

Done.

[Raymond Toy, 2017-02-28 23:26:11]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-28 23:26:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2708953003/#ps260001
(title: "Address review comments.")

[commit-bot: I haz the power, 2017-02-28 23:26:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 00:28:31]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1488324371807900,
"parent_rev": "d6a8436e67d97350649ca029d212699a93af5e67", "commit_rev":
"6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc"}

[commit-bot: I haz the power, 2017-03-01 00:29:26]

Description was changed from

==========
Move task.describe descriptiosn to audit.define

Move the description of the task into the first argument
audit.define.  This is the first step at removing support for
task.describe.

The conversion was done using the gawk script:

/^ *audit.define\(/ {
  audit = $0
  next
}
/^ *task.describe\(.*\);/ {
  desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat);
  label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat)
  printf "%saudit.define({\n", label_pat[1]
  printf "%s  label: %s,\n", label_pat[1], label_pat[2]
  printf "%s  description: %s\n", label_pat[1], desc_pat[2]
  printf "%s},%s", label_pat[1], label_pat[3]
  next
}
{ print }

This script tries to indent things reasonably nicely, but doesn't
handle the case where the description is very long or where the indentation is
different.

Also, not all files could be converted automatically because the
script is not smart enough.  These will be handled separately.

BUG=694659
TEST=none
==========

to

==========
Move task.describe descriptiosn to audit.define

Move the description of the task into the first argument
audit.define.  This is the first step at removing support for
task.describe.

The conversion was done using the gawk script:

/^ *audit.define\(/ {
  audit = $0
  next
}
/^ *task.describe\(.*\);/ {
  desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat);
  label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat)
  printf "%saudit.define({\n", label_pat[1]
  printf "%s  label: %s,\n", label_pat[1], label_pat[2]
  printf "%s  description: %s\n", label_pat[1], desc_pat[2]
  printf "%s},%s", label_pat[1], label_pat[3]
  next
}
{ print }

This script tries to indent things reasonably nicely, but doesn't
handle the case where the description is very long or where the indentation is
different.

Also, not all files could be converted automatically because the
script is not smart enough.  These will be handled separately.

BUG=694659
TEST=none

Review-Url: https://codereview.chromium.org/2708953003
Cr-Commit-Position: refs/heads/master@{#453770}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ae3ac58c9bc4d6c20a3ec2dab0b...
==========

[commit-bot: I haz the power, 2017-03-01 00:29:27]

Committed patchset #13 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/6ae3ac58c9bc4d6c20a3ec2dab0b...