Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html

Issue 2708953003: Move task.describe descriptions to audit.define (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html b/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html
index 9bd1a7da5649d883fd82579bac81c6783672d213..a79e6a999b3ad8ebec94d3160299ef8843253b2c 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html
@@ -22,8 +22,10 @@
let audit = Audit.createTaskRunner();
// Task: test suspend().
- audit.define('test-suspend', function (task, should) {
- task.describe("Test suspend() for offline context");
+ audit.define({
+ label: 'test-suspend',
+ description: "Test suspend() for offline context"
+ }, function (task, should) {
// Test suspend/resume. Ideally this test is best with a online
// AudioContext, but content shell doesn't really have a working online
// AudioContext. Hence, use an OfflineAudioContext. Not all possible
@@ -63,8 +65,10 @@
// Task: test resume().
- audit.define('test-resume', function (task, should) {
- task.describe("Test resume() for offline context");
+ audit.define({
+ label: 'test-resume',
+ description: "Test resume() for offline context"
+ }, function (task, should) {
// Multiple calls to resume should not be a problem. But we can't test
// that on an offline context. Thus, check that resume() on an
// OfflineAudioContext rejects the promise.
@@ -83,8 +87,10 @@
});
// Task: test the state after context closed.
- audit.define('test-after-close', function (task, should) {
- task.describe("Test state after context closed");
+ audit.define({
+ label: 'test-after-close',
+ description: "Test state after context closed"
+ }, function (task, should) {
// Render the offline context.
osc.start();

Powered by Google App Engine
This is Rietveld 408576698