third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html - Issue 2708953003: Move task.describe descriptions to audit.define

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html

Issue 2708953003: Move task.describe descriptions to audit.define (Closed)

Patch Set: Address review comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-bandpass.html ('k') | third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-highpass.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">	1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/testharness.js"></script>	4 <script src="../../resources/testharness.js"></script>

5 <script src="../../resources/testharnessreport.js"></script>	5 <script src="../../resources/testharnessreport.js"></script>

6 <script src="../resources/audit-util.js"></script>	6 <script src="../resources/audit-util.js"></script>

7 <script src="../resources/audit.js"></script>	7 <script src="../resources/audit.js"></script>

8 <script src="../resources/biquad-filters.js"></script>	8 <script src="../resources/biquad-filters.js"></script>

9 <script src="../resources/biquad-testing.js"></script>	9 <script src="../resources/biquad-testing.js"></script>

10 </head>	10 </head>

(...skipping 232 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
243 ' deg) in phase response at frequency ' +	243 ' deg) in phase response at frequency ' +

244 frequencies[maxPhaseErrorIndex] + ' Hz')	244 frequencies[maxPhaseErrorIndex] + ' Hz')

245 .beLessThanOrEqualTo(radToDegree(maxAllowedPhaseError));	245 .beLessThanOrEqualTo(radToDegree(maxAllowedPhaseError));

246 }	246 }

247	247

248 function radToDegree(rad) {	248 function radToDegree(rad) {

249 // Radians to degrees	249 // Radians to degrees

250 return rad * 180 / Math.PI;	250 return rad * 180 / Math.PI;

251 }	251 }

252	252

253 audit.define("test", function (task, should) {	253 audit.define({

254 task.describe("Biquad frequency response");	254 label: "test",

	255 description: "Biquad frequency response"

	256 }, function (task, should) {

255 context = new AudioContext();	257 context = new AudioContext();

256	258

257 filter = context.createBiquadFilter();	259 filter = context.createBiquadFilter();

258	260

259 // Arbitrarily test a peaking filter, but any kind of filter can be tested.	261 // Arbitrarily test a peaking filter, but any kind of filter can be tested.

260 filter.type = "peaking";	262 filter.type = "peaking";

261 filter.frequency.value = filterCutoff;	263 filter.frequency.value = filterCutoff;

262 filter.Q.value = filterQ;	264 filter.Q.value = filterQ;

263 filter.gain.value = filterGain;	265 filter.gain.value = filterGain;

264	266

265 var frequencies = createFrequencies(numberOfFrequencies, context.sampleRate) ;	267 var frequencies = createFrequencies(numberOfFrequencies, context.sampleRate) ;

266 magResponse = new Float32Array(numberOfFrequencies);	268 magResponse = new Float32Array(numberOfFrequencies);

267 phaseResponse = new Float32Array(numberOfFrequencies);	269 phaseResponse = new Float32Array(numberOfFrequencies);

268	270

269 filter.getFrequencyResponse(frequencies, magResponse, phaseResponse);	271 filter.getFrequencyResponse(frequencies, magResponse, phaseResponse);

270 compareResponses(should, filter, frequencies, magResponse, phaseResponse);	272 compareResponses(should, filter, frequencies, magResponse, phaseResponse);

271	273

272 task.done();	274 task.done();

273 });	275 });

274	276

275 audit.run();	277 audit.run();

276 </script>	278 </script>

277	279

278 </body>	280 </body>

279 </html>	281 </html>

OLD	NEW