Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Gain/gain.html

Issue 2708953003: Move task.describe descriptions to audit.define (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Gain/gain.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html b/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html
index bc66ed6c431b680c4eb4d1b8eae0cda8d081dccf..b948c31ff543cc6af8cd4048fa7087c22cb5e8d0 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html
@@ -59,16 +59,20 @@ function playNote(time, gain) {
source.start(time);
}
-audit.define('create context', function(task, should) {
- task.describe('Create context for test');
+audit.define({
+ label: 'create context',
+ description: 'Create context for test'
+}, function(task, should) {
// Create offline audio context.
context =
new OfflineAudioContext(2, sampleRate * lengthInSeconds, sampleRate);
task.done();
});
-audit.define('load-ref', function(task, should) {
- task.describe('Load reference audio file');
+audit.define({
+ label: 'load-ref',
+ description: 'Load reference audio file'
+}, function(task, should) {
let bufferLoader =
new BufferLoader(context, ['gain-expected.wav'], bufferList => {
reference = bufferList[0].getChannelData(0);
@@ -78,8 +82,10 @@ audit.define('load-ref', function(task, should) {
bufferLoader.load();
});
-audit.define('test', function(task, should) {
- task.describe('GainNode functionality');
+audit.define({
+ label: 'test',
+ description: 'GainNode functionality'
+}, function(task, should) {
// Create a buffer for a short "note".
sinWaveBuffer = createSinWaveBuffer(bufferDurationSeconds, 880.0);

Powered by Google App Engine
This is Rietveld 408576698