third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html - Issue 2708953003: Move task.describe descriptions to audit.define

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

Issue 2708953003: Move task.describe descriptions to audit.define (Closed)

Patch Set: Address review comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-basic.html ('k') | third_party/WebKit/LayoutTests/webaudio/Gain/gain.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html b/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

index 3d09f4fbd889f7c2b7f31ea685779916b53aee48..7ca1ea9dedba3682595286244aa1f76baafb0a7b 100644

--- a/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

+++ b/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

@@ -42,8 +42,10 @@

.beTrue();

}

- audit.define("test", function (task, should) {

- task.describe("Test pre-emphasis in DynamicsCompressor is removed");

+ audit.define({

+ label: "test",

+ description: "Test pre-emphasis in DynamicsCompressor is removed"

+ }, function (task, should) {

context = new OfflineAudioContext(1, sampleRate * lengthInSeconds, sampleRate);

// Connect an oscillator to a gain node to the compressor. The