Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2702403004: Expand FrameSeleciton::start() to increase chances of hoisting update layout (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews, dcheng, dtapuska+blinkwatch_chromium.org, groby+blinkspell_chromium.org, kinuko+watch, mlamouri+watch-blink_chromium.org, Navid Zolghadr, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand FrameSeleciton::start() to increase chances of hoisting update layout This patch expands |FrameSeleciton::start()| to increase chance of hoisting update layout. Note: This is mechanical change to replace |selection().start()| by |selection().computeVisibleSelectionInDOMTreeDeprecated().start()| Following patch will remove deprecated version. This patch is apart of expanding expensive member functions in |FrameSelection|: - rootEditableElement() - hasEditableStyle() - isContentEditable() - isContentRichlyEditable() - getSelectionType() - base() - extent() - start() - end() - isNone() - isCaret() - isRange() BUG=694360 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2702403004 Cr-Commit-Position: refs/heads/master@{#451939} Committed: https://chromium.googlesource.com/chromium/src/+/871eda697365b8e2f6513bb3ccb376bc27ef4bbe

Patch Set 1 : 2017-02-22T12:32:36 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -34 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 2 chunks +18 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 4 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yosin_UTC9
PTAL Changes in core/clipboard/, core/editing/, core/input/ and web/
3 years, 10 months ago (2017-02-22 06:52:52 UTC) #5
tkent
lgtm
3 years, 10 months ago (2017-02-22 07:34:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702403004/1
3 years, 10 months ago (2017-02-22 07:36:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 08:54:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/871eda697365b8e2f6513bb3ccb3...

Powered by Google App Engine
This is Rietveld 408576698