Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

Issue 2702403004: Expand FrameSeleciton::start() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-22T12:32:36 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
index cfca437097a7b9dbf2570f197d4774406647c901..b8560628d041d0b45c48d038a974116b19efe562 100644
--- a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
+++ b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
@@ -66,7 +66,10 @@ bool Editor::handleEditingKeyboardEvent(KeyboardEvent* evt) {
return false;
}
if (!focusedElement->containsIncludingHostElements(
- *m_frame->selection().start().computeContainerNode())) {
+ *m_frame->selection()
+ .computeVisibleSelectionInDOMTreeDeprecated()
+ .start()
+ .computeContainerNode())) {
// We should not insert text at selection start if selection doesn't have
// focus. See http://crbug.com/89026
return false;
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698