third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 2702403004: Expand FrameSeleciton::start() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2702403004: Expand FrameSeleciton::start() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-22T12:32:36 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

index eb342fb71ba02c2ded8f4f3f5f734ed710489f48..b4bbb9cf44b36a31fa9af27653b4940bc767c086 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

@@ -193,7 +193,11 @@ TEST_F(InputMethodControllerTest, SetCompositionAfterEmoji) {

document().updateStyleAndLayout();

controller().setEditableSelectionOffsets(PlainTextRange(2, 2));

- EXPECT_EQ(2, frame().selection().start().computeOffsetInContainerNode());

+ EXPECT_EQ(2, frame()

+ .selection()

+ .computeVisibleSelectionInDOMTreeDeprecated()

+ .start()

+ .computeOffsetInContainerNode());

EXPECT_EQ(2, frame()

.selection()

.computeVisibleSelectionInDOMTreeDeprecated()

@@ -345,7 +349,11 @@ TEST_F(InputMethodControllerTest, SelectionOnConfirmExistingText) {

controller().setCompositionFromExistingText(underlines, 0, 5);

controller().finishComposingText(InputMethodController::KeepSelection);

- EXPECT_EQ(0, frame().selection().start().computeOffsetInContainerNode());

+ EXPECT_EQ(0, frame()