Expand FrameSeleciton::start() to increase chances of hoisting update layout

third_party/WebKit/Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 676 matching lines @@
                options);
   m_selectionEditor->setLogicalRange(logicalRange);
   return true;
 }
 
 Range* FrameSelection::firstRange() const {
   return m_selectionEditor->firstRange();
 }
 
 bool FrameSelection::isInPasswordField() const {
-  TextControlElement* textControl = enclosingTextControl(start());
+  TextControlElement* textControl = enclosingTextControl(
+      computeVisibleSelectionInDOMTreeDeprecated().start());
   return isHTMLInputElement(textControl) &&
          toHTMLInputElement(textControl)->type() == InputTypeNames::password;
 }
 
 void FrameSelection::notifyAccessibilityForSelectionChange() {
   if (selectionInDOMTree().isNone())
     return;
   AXObjectCache* cache = document().existingAXObjectCache();
   if (!cache)
     return;
@@ skipping 230 matching lines @@
   return 0;
 }
 
 // We look for either the form containing the current focus, or for one
 // immediately after it
 HTMLFormElement* FrameSelection::currentForm() const {
   // Start looking either at the active (first responder) node, or where the
   // selection is.
   Node* start = document().focusedElement();
   if (!start)
-    start = this->start().anchorNode();
+    start = computeVisibleSelectionInDOMTreeDeprecated().start().anchorNode();
   if (!start)
     return 0;
 
   // Try walking up the node tree to find a form element.
   for (HTMLElement* element =
            Traversal<HTMLElement>::firstAncestorOrSelf(*start);
        element; element = Traversal<HTMLElement>::firstAncestor(*element)) {
     if (HTMLFormElement* form = associatedFormElement(*element))
       return form;
   }
@@ skipping 20 matching lines @@
       rect = LayoutRect(absoluteCaretBounds());
       break;
     case RangeSelection:
       rect = LayoutRect(
           revealExtentOption == RevealExtent
               ? absoluteCaretBoundsOf(createVisiblePosition(extent()))
               : enclosingIntRect(unclippedBounds()));
       break;
   }
 
-  Position start = this->start();
+  Position start = computeVisibleSelectionInDOMTreeDeprecated().start();
   DCHECK(start.anchorNode());
   if (start.anchorNode() && start.anchorNode()->layoutObject()) {
     // FIXME: This code only handles scrolling the startContainer's layer, but
     // the selection rect could intersect more than just that.
     if (DocumentLoader* documentLoader = m_frame->loader().documentLoader())
       documentLoader->initialScrollState().wasScrolledByUser = true;
     if (start.anchorNode()->layoutObject()->scrollRectToVisible(rect, alignment,
                                                                 alignment))
       updateAppearance();
   }
@@ skipping 177 matching lines @@
 }
 
 void showTree(const blink::FrameSelection* sel) {
   if (sel)
     sel->showTreeForThis();
   else
     LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
 }
 
 #endif