third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 2702403004: Expand FrameSeleciton::start() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2702403004: Expand FrameSeleciton::start() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-22T12:32:36 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index 925929f74d2aaac9fa30a0684cf1d7195b11fbe1..740bf93ec79a6804c131a342fb2a0ec9b45738ce 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -602,8 +602,10 @@ bool WebFrameWidgetImpl::selectionTextDirection(WebTextDirection& start,

.toNormalizedEphemeralRange()

.isNull())

return false;

- start =

- toWebTextDirection(primaryDirectionOf(*selection.start().anchorNode()));

+ start = toWebTextDirection(

+ primaryDirectionOf(*selection.computeVisibleSelectionInDOMTreeDeprecated()

+ .start()

+ .anchorNode()));

end = toWebTextDirection(

primaryDirectionOf(*selection.computeVisibleSelectionInDOMTreeDeprecated()

.end()