Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act…

Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-activation' to be consistent with the spec proposal: http://github.com/whatwg/html/pull/2292.

Also changed the tests to be testharness-based for the merging into web-platform-tests.

BUG=662506
Review-Url: https://codereview.chromium.org/2696703010
Cr-Commit-Position: refs/heads/master@{#452368}
Committed: https://chromium.googlesource.com/chromium/src/+/8926e98b4c2426be840b2deb8401e501b971f045

[Bin Lu, 2017-02-16 22:26:39]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 22:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:31:15]

Dry run: This issue passed the CQ dry run.

[Bin Lu, 2017-02-17 05:24:55]

Description was changed from

==========
Rename the flag of 'allow-top-navigation-with-user-activation' to
'allow-top-navigation-by-user-activation' to be consistent with the spec
proposal: http://github.com/whatwg/html/pull/2292.

BUG=662506
==========

to

==========
Rename the flag of 'allow-top-navigation-with-user-activation' to
'allow-top-navigation-by-user-activation' to be consistent with the spec
proposal: http://github.com/whatwg/html/pull/2292.

BUG=662506
==========

[Bin Lu, 2017-02-17 05:24:56]

binlu@google.com changed reviewers:
+ japhet@chromium.org, ojan@chromium.org, rbyers@chromium.org

[Bin Lu, 2017-02-20 15:49:11]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 15:49:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bin Lu, 2017-02-20 15:55:43]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 15:55:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bin Lu, 2017-02-20 15:56:57]

Description was changed from

==========
Rename the flag of 'allow-top-navigation-with-user-activation' to
'allow-top-navigation-by-user-activation' to be consistent with the spec
proposal: http://github.com/whatwg/html/pull/2292.

BUG=662506
==========

to

==========
Rename the flag of 'allow-top-navigation-with-user-activation' to
'allow-top-navigation-by-user-activation' to be consistent with the spec
proposal: http://github.com/whatwg/html/pull/2292.

Also changed the tests to be testharness-based for the merging into
web-platform-tests.

BUG=662506
==========

[Bin Lu, 2017-02-20 15:58:45]

Any idea on how to emulate user gesture for web-platform-tests? It seems that
window.eventSender is only available in webkit/blink.

[commit-bot: I haz the power, 2017-02-20 19:10:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 19:10:01]

Dry run: This issue passed the CQ dry run.

[domenic, 2017-02-21 18:37:43]

domenic@chromium.org changed reviewers:
+ domenic@chromium.org

[domenic, 2017-02-21 18:37:43]

On 2017/02/20 at 15:58:45, binlu wrote:
> Any idea on how to emulate user gesture for web-platform-tests? It seems that
window.eventSender is only available in webkit/blink.

rbyers@ might know more, but I think such web platform tests for the case of
allowing it given a user gesture will have to be manual tests :(. They can still
live in the WPT repository though.

That means we'll have some non-upstreamable tests using eventSender still living
in Blink.

The case of disallowing it given no gesture should be easy enough to upstream,
though.

https://codereview.chromium.org/2696703010/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html
(right):

https://codereview.chromium.org/2696703010/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html:6:
if (window.testRunner) {
Probably all this window.testRunner stuff should go away? Here and in other
files?

https://codereview.chromium.org/2696703010/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html:13:
test(function() {
I think this should be async_test. Then line 14 should use test.step_func. See
http://web-platform-tests.org/writing-tests/testharness-api.html

[Bin Lu, 2017-02-22 05:05:16]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 05:06:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bin Lu, 2017-02-22 05:23:44]

Thanks Domenic for the review.

Added a test for setting both 'allow-top-navigation' &
'allow-top-navigation-by-user-activation'.

> The case of disallowing it given no gesture should be easy enough to upstream,
though.
Should I move the test files for disallowing it given no gesture to the dir of
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/...

Do it in a follow-up CL together with the manual tests?

https://codereview.chromium.org/2696703010/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html
(right):

https://codereview.chromium.org/2696703010/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html:6:
if (window.testRunner) {
On 2017/02/21 18:37:43, domenic wrote:
> Probably all this window.testRunner stuff should go away? Here and in other
> files?

Done for the case of disallowing it given no gesture. But for other files, I
tried and didn't find a way to run the test with testharness.js for successful
top navigation since setting top.location will destroy the origin top-level page
in which the async_test always timed out. So I reverted back to use testRunner
for the successful top navigations.

Any idea on how to test for successful top navigation with async_test? Thanks.

https://codereview.chromium.org/2696703010/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html:13:
test(function() {
On 2017/02/21 18:37:43, domenic wrote:
> I think this should be async_test. Then line 14 should use test.step_func. See
> http://web-platform-tests.org/writing-tests/testharness-api.html

Done. Thanks for the pointer!

[commit-bot: I haz the power, 2017-02-22 07:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:15:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bin Lu, 2017-02-22 11:03:11]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 11:03:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 12:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 12:44:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[domenic, 2017-02-22 22:21:29]

On 2017/02/22 at 05:23:44, binlu wrote:
> Thanks Domenic for the review.
> 
> Added a test for setting both 'allow-top-navigation' &
'allow-top-navigation-by-user-activation'.
> 
> > The case of disallowing it given no gesture should be easy enough to
upstream, though.
> Should I move the test files for disallowing it given no gesture to the dir of
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/...
> 
> Do it in a follow-up CL together with the manual tests?

A follow-up CL with manual tests makes sense to me.

> Done for the case of disallowing it given no gesture. But for other files, I
tried and didn't find a way to run the test with testharness.js for successful
top navigation since setting top.location will destroy the origin top-level page
in which the async_test always timed out. So I reverted back to use testRunner
for the successful top navigations.
> 
> Any idea on how to test for successful top navigation with async_test? Thanks.

Hmm, I kind of hoped things would just keep working after successful top
navigation, but I guess not :).

Since the web platform test versions of these have to be manual tests anyway, I
guess it makes sense to stick with testRunner for the non-web-platform-test
versions in Blink.

[domenic, 2017-02-22 22:36:00]

I don't believe I'm a reviewer, but lgtm :)

[Rick Byers, 2017-02-22 22:59:20]

On 2017/02/21 18:37:43, domenic wrote:
> On 2017/02/20 at 15:58:45, binlu wrote:
> > Any idea on how to emulate user gesture for web-platform-tests? It seems
that
> window.eventSender is only available in webkit/blink.
> 
> rbyers@ might know more, but I think such web platform tests for the case of
> allowing it given a user gesture will have to be manual tests :(. They can
still
> live in the WPT repository though.
> 
> That means we'll have some non-upstreamable tests using eventSender still
living
> in Blink.

Yeah, feel free to just leave it that way.

We do have some cases of upstreaming such a test as a "-manual.html" test, while
still hooking up input automation when run in blink infrastructure (see the
wpt/pointerevents/ directory, and wpt_automation/pointerevents).  But it's a
kludge.  https://github.com/w3c/web-platform-tests/issues/2161 tracks a proper
standardized solution to input automation in WPT.

[Rick Byers, 2017-02-22 23:00:26]

LGTM

[Bin Lu, 2017-02-22 23:02:24]

The CQ bit was checked by binlu@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 23:04:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 00:58:11]

Dry run: This issue passed the CQ dry run.

[Bin Lu, 2017-02-23 03:06:40]

The CQ bit was checked by binlu@google.com

[Bin Lu, 2017-02-23 03:06:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2696703010/#ps80001
(title: "Add the *-with-two-flags-expected.txt that I forgot previously.")

[commit-bot: I haz the power, 2017-02-23 03:07:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 03:12:28]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487819200577320,
"parent_rev": "26664a7d9d2e37eeaaf5f565cb651a4f37c4e438", "commit_rev":
"8926e98b4c2426be840b2deb8401e501b971f045"}

[commit-bot: I haz the power, 2017-02-23 03:13:06]

Description was changed from

==========
Rename the flag of 'allow-top-navigation-with-user-activation' to
'allow-top-navigation-by-user-activation' to be consistent with the spec
proposal: http://github.com/whatwg/html/pull/2292.

Also changed the tests to be testharness-based for the merging into
web-platform-tests.

BUG=662506
==========

to

==========
Rename the flag of 'allow-top-navigation-with-user-activation' to
'allow-top-navigation-by-user-activation' to be consistent with the spec
proposal: http://github.com/whatwg/html/pull/2292.

Also changed the tests to be testharness-based for the merging into
web-platform-tests.

BUG=662506

Review-Url: https://codereview.chromium.org/2696703010
Cr-Commit-Position: refs/heads/master@{#452368}
Committed:
https://chromium.googlesource.com/chromium/src/+/8926e98b4c2426be840b2deb8401...
==========

[commit-bot: I haz the power, 2017-02-23 03:13:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8926e98b4c2426be840b2deb8401...

[Bin Lu, 2017-02-23 04:51:24]

Patchset #6 (id:100001) has been deleted