third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html - Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act…

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html

Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act… (Closed)

Patch Set: Change the tests to be testharness-based for the merging into web-platform-tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

3 <script>	5 <script>

4 if (window.testRunner) {	6 if (window.testRunner) {
	domenic 2017/02/21 18:37:43 Probably all this window.testRunner stuff should g Probably all this window.testRunner stuff should go away? Here and in other files? Bin Lu 2017/02/22 05:23:43 Done for the case of disallowing it given no gestu Show quoted text On 2017/02/21 18:37:43, domenic wrote: > Probably all this window.testRunner stuff should go away? Here and in other > files? Done for the case of disallowing it given no gesture. But for other files, I tried and didn't find a way to run the test with testharness.js for successful top navigation since setting top.location will destroy the origin top-level page in which the async_test always timed out. So I reverted back to use testRunner for the successful top navigations. Any idea on how to test for successful top navigation with async_test? Thanks.
5 testRunner.dumpAsText();	7 testRunner.dumpAsText();

6 testRunner.dumpChildFramesAsText();	8 testRunner.dumpChildFramesAsText();

7 testRunner.setDumpConsoleMessages(false);	9 testRunner.setDumpConsoleMessages(false);

8 testRunner.waitUntilDone();	10 testRunner.waitUntilDone();

9 }	11 }

10	12

11 window.addEventListener("message", e => {	13 test(function() {
	domenic 2017/02/21 18:37:43 I think this should be async_test. Then line 14 sh I think this should be async_test. Then line 14 should use test.step_func. See http://web-platform-tests.org/writing-tests/testharness-api.html Bin Lu 2017/02/22 05:23:44 Done. Thanks for the pointer! Show quoted text On 2017/02/21 18:37:43, domenic wrote: > I think this should be async_test. Then line 14 should use test.step_func. See > http://web-platform-tests.org/writing-tests/testharness-api.html Done. Thanks for the pointer!
12 if (e.data == "PASS")	14 window.addEventListener("message", e => {

13 testRunner.notifyDone();	15 assert_equals(e.data, "PASS", "The message says 'PASS' instead of 'FAIL'");

14 else	16 });

15 testRunner.testFailed("'top.location' didn't throw.");	17 }, "The sandboxed iframe posted a message saying the test was in the state of 'P ASS'.");

16 });

17 </script>	18 </script>

18 </head>	19 </head>

19 <body>	20 <body>

20 <p>This tests that an iframe in sandbox with 'allow-top-navigation-with-user -activation'	21 <p>This tests that an iframe in sandbox with 'allow-top-navigation-by-user-a ctivation'

21 cannot navigate its top level page, if it is not trigged by a user gesture.< /p>	22 cannot navigate its top level page, if it is not trigged by a user gesture.< /p>

22 <iframe sandbox='allow-top-navigation-with-user-activation allow-scripts' sr c="http://localhost:8000/security/frameNavigation/resources/iframe-that-performs -top-navigation-without-user-gesture-failed.html"></iframe>	23 <iframe sandbox='allow-top-navigation-by-user-activation allow-scripts' src= "resources/iframe-that-performs-top-navigation-without-user-gesture-failed.html" ></iframe>

23 </body>	24 </body>

24 </html>	25 </html>

OLD	NEW