third_party/WebKit/Source/core/dom/SandboxFlags.h - Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SandboxFlags.h

Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act… (Closed)

Patch Set: Add the *-with-two-flags-expected.txt that I forgot previously. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SandboxFlags.h

diff --git a/third_party/WebKit/Source/core/dom/SandboxFlags.h b/third_party/WebKit/Source/core/dom/SandboxFlags.h

index 538bd3e3630c0dcb1f58b402a9c4ab2dbfb77b31..ab15a6072287863160fcf10056fdcffc90ff3b4b 100644

--- a/third_party/WebKit/Source/core/dom/SandboxFlags.h

+++ b/third_party/WebKit/Source/core/dom/SandboxFlags.h

@@ -56,7 +56,7 @@ enum SandboxFlag {

// https://w3c.github.io/presentation-api/#sandboxing-and-the-allow-presentation-keyword

SandboxPresentation = 1 << 13,

// See https://github.com/WICG/interventions/issues/42.

- SandboxTopNavigationWithUserActivation = 1 << 14,

+ SandboxTopNavigationByUserActivation = 1 << 14,

SandboxAll = -1 // Mask with all bits set to 1.

};