third_party/WebKit/Source/core/dom/SandboxFlags.cpp - Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SandboxFlags.cpp

Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act… (Closed)

Patch Set: Add the *-with-two-flags-expected.txt that I forgot previously. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SandboxFlags.cpp

diff --git a/third_party/WebKit/Source/core/dom/SandboxFlags.cpp b/third_party/WebKit/Source/core/dom/SandboxFlags.cpp

index 34e62da1ba50ddd0f22037045393c081cd60afca..9953670db5c55de5f750138d1223947d013d1378 100644

--- a/third_party/WebKit/Source/core/dom/SandboxFlags.cpp

+++ b/third_party/WebKit/Source/core/dom/SandboxFlags.cpp

@@ -68,10 +68,10 @@ SandboxFlags parseSandboxPolicy(const SpaceSplitString& policy,

} else if (equalIgnoringCase(sandboxToken, "allow-presentation")) {

flags &= ~SandboxPresentation;

} else if (equalIgnoringCase(sandboxToken,

- "allow-top-navigation-with-user-activation") &&

+ "allow-top-navigation-by-user-activation") &&

RuntimeEnabledFeatures::

- topNavWithUserActivationInSandboxEnabled()) {

- flags &= ~SandboxTopNavigationWithUserActivation;

+ topNavByUserActivationInSandboxEnabled()) {

+ flags &= ~SandboxTopNavigationByUserActivation;

} else {

tokenErrors.append(tokenErrors.isEmpty() ? "'" : ", '");

tokenErrors.append(sandboxToken);