third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html - Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture.html

Issue 2696703010: Rename the flag of 'allow-top-navigation-with-user-activation' to 'allow-top-navigation-by-user-act… (Closed)

Patch Set: Add the *-with-two-flags-expected.txt that I forgot previously. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture.html ('k') | third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-without-user-gesture-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 <!doctype html>

1 <html>	2 <html>

2 <head>	3 <head>

	4 <script src="/resources/testharness.js"></script>

	5 <script src="/resources/testharnessreport.js"></script>

3 <script>	6 <script>

4 if (window.testRunner) {	7 async_test(function(t) {

5 testRunner.dumpAsText();	8 window.addEventListener("message", t.step_func_done(function(e) {

6 testRunner.dumpChildFramesAsText();	9 assert_equals(e.data, "PASS", "The message should say 'PASS' instead of 'F AIL'");

7 testRunner.setDumpConsoleMessages(false);	10 }));

8 testRunner.waitUntilDone();	11 }, "The sandboxed iframe should post a message saying the test was in the state of 'PASS'.");

9 }

10

11 window.addEventListener("message", e => {

12 if (e.data == "PASS")

13 testRunner.notifyDone();

14 else

15 testRunner.testFailed("'top.location' didn't throw.");

16 });

17 </script>	12 </script>

18 </head>	13 </head>

19 <body>	14 <body>

20 <p>This tests that an iframe in sandbox with 'allow-top-navigation-with-user -activation'	15 <p>This tests that an iframe in sandbox with 'allow-top-navigation-by-user-a ctivation'

21 cannot navigate its top level page, if it is not trigged by a user gesture.< /p>	16 cannot navigate its top level page, if it is not trigged by a user gesture.< /p>

22 <iframe sandbox='allow-top-navigation-with-user-activation allow-scripts' sr c="http://localhost:8000/security/frameNavigation/resources/iframe-that-performs -top-navigation-without-user-gesture-failed.html"></iframe>	17 <iframe sandbox='allow-top-navigation-by-user-activation allow-scripts' src= "resources/iframe-that-performs-top-navigation-without-user-gesture-failed.html" ></iframe>

23 </body>	18 </body>

24 </html>	19 </html>

OLD	NEW