Use ScopedCrashKey for RendererDidNavigate crash dumps

Use ScopedCrashKey for RendererDidNavigate crash dumps

This will make the crash reports easier to view.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2696193006
Cr-Commit-Position: refs/heads/master@{#451501}
Committed: https://chromium.googlesource.com/chromium/src/+/b1730dabdf125160dc23db993e08f453fc648fc8

[estark, 2017-02-17 17:05:41]

Description was changed from

==========
Use ScopedCrashKey for RendererDidNavigate crash dumps

This will make the crash reports easier to view.

BUG=688425
==========

to

==========
Use ScopedCrashKey for RendererDidNavigate crash dumps

This will make the crash reports easier to view.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[estark, 2017-02-17 17:05:46]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 17:06:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-02-17 17:12:38]

estark@chromium.org changed reviewers:
+ creis@chromium.org

[estark, 2017-02-17 17:12:39]

creis, could you please take a look? (looks like jam and nasko who have been
investigating this bug with me are OOO)

[Charlie Reis, 2017-02-17 17:30:54]

The ScopedCrashKey change LGTM.  I'm curious about the collected data, though--
what's the theory you're trying to test?

[estark, 2017-02-17 17:31:20]

The CQ bit was unchecked by estark@chromium.org

[estark, 2017-02-17 17:31:25]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-02-17 17:32:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 18:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 18:10:45]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[estark, 2017-02-17 19:26:31]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[estark, 2017-02-17 19:27:35]

estark@chromium.org changed reviewers:
+ ananta@chromium.org, rsesek@chromium.org

[estark, 2017-02-17 19:27:36]

rsesek, can you please review chrome/common/crash_keys.cc?
ananta, can you please review chrome/app/chrome_crash_reporter_client_win.cc?

[commit-bot: I haz the power, 2017-02-17 19:27:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-02-17 19:30:07]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:30:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2017-02-17 19:31:20]

chrome_crash_reporter_client_win.cc lgtm

[Robert Sesek, 2017-02-17 19:33:46]

lgtm

[estark, 2017-02-17 19:38:41]

The CQ bit was unchecked by estark@chromium.org

[estark, 2017-02-17 19:38:52]

The CQ bit was checked by estark@chromium.org

[estark, 2017-02-17 19:38:52]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2696193006/#ps60001
(title: "revert unrelated 'git cl format' changes")

[commit-bot: I haz the power, 2017-02-17 19:39:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:31:16]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[estark, 2017-02-18 18:35:53]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 18:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 20:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 20:05:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estark, 2017-02-18 23:01:00]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-02-18 23:01:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 00:06:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487458860812410,
"parent_rev": "bce53455673368a99e755d09ca7871c38a252c0a", "commit_rev":
"b1730dabdf125160dc23db993e08f453fc648fc8"}

[commit-bot: I haz the power, 2017-02-19 00:07:06]

Description was changed from

==========
Use ScopedCrashKey for RendererDidNavigate crash dumps

This will make the crash reports easier to view.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Use ScopedCrashKey for RendererDidNavigate crash dumps

This will make the crash reports easier to view.

BUG=688425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2696193006
Cr-Commit-Position: refs/heads/master@{#451501}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1730dabdf125160dc23db993e08...
==========

[commit-bot: I haz the power, 2017-02-19 00:07:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b1730dabdf125160dc23db993e08...

[jam, 2017-02-21 18:40:04]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2705303002/ by jam@chromium.org.

The reason for reverting is: We got the data we wanted..