Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3065)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2696193006: Use ScopedCrashKey for RendererDidNavigate crash dumps (Closed)
Patch Set: revert unrelated 'git cl format' changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.cc
diff --git a/chrome/app/chrome_crash_reporter_client_win.cc b/chrome/app/chrome_crash_reporter_client_win.cc
index ba0a9b980c346cca3cfb2217016bb4b4e21286d8..8f5211e4812eb9c00dd304deada978ef5e2b5be1 100644
--- a/chrome/app/chrome_crash_reporter_client_win.cc
+++ b/chrome/app/chrome_crash_reporter_client_win.cc
@@ -114,7 +114,7 @@ size_t RegisterCrashKeysHelper() {
{"discardable-memory-allocated", kSmallSize},
{"discardable-memory-free", kSmallSize},
{kFontKeyName, kSmallSize},
- { "mojo-message-error", kMediumSize },
+ {"mojo-message-error", kMediumSize},
{"ppapi_path", kMediumSize},
{"subresource_url", kLargeSize},
{"total-discardable-memory-allocated", kSmallSize},
@@ -165,21 +165,21 @@ size_t RegisterCrashKeysHelper() {
{"initrf_root_proxy_is_live", kSmallSize},
// Temporary for https://crbug.com/626802.
- { "newframe_routing_id", kSmallSize },
- { "newframe_proxy_id", kSmallSize },
- { "newframe_opener_id", kSmallSize },
- { "newframe_parent_id", kSmallSize },
- { "newframe_widget_id", kSmallSize },
- { "newframe_widget_hidden", kSmallSize },
- { "newframe_replicated_origin", kSmallSize },
- { "newframe_oopifs_possible", kSmallSize },
+ {"newframe_routing_id", kSmallSize},
+ {"newframe_proxy_id", kSmallSize},
+ {"newframe_opener_id", kSmallSize},
+ {"newframe_parent_id", kSmallSize},
+ {"newframe_widget_id", kSmallSize},
+ {"newframe_widget_hidden", kSmallSize},
+ {"newframe_replicated_origin", kSmallSize},
+ {"newframe_oopifs_possible", kSmallSize},
// Temporary for https://crbug.com/630103.
- { "origin_mismatch_url", crash_keys::kLargeSize },
- { "origin_mismatch_origin", crash_keys::kMediumSize },
- { "origin_mismatch_transition", crash_keys::kSmallSize },
- { "origin_mismatch_redirects", crash_keys::kSmallSize },
- { "origin_mismatch_same_page", crash_keys::kSmallSize },
+ {"origin_mismatch_url", crash_keys::kLargeSize},
+ {"origin_mismatch_origin", crash_keys::kMediumSize},
+ {"origin_mismatch_transition", crash_keys::kSmallSize},
+ {"origin_mismatch_redirects", crash_keys::kSmallSize},
+ {"origin_mismatch_same_page", crash_keys::kSmallSize},
// Temporary for https://crbug.com/612711.
{"aci_wrong_sp_extension_id", kSmallSize},
@@ -198,6 +198,10 @@ size_t RegisterCrashKeysHelper() {
{"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize},
{"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize},
{"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize},
+
+ // Temporary for https://crbug.com/688425
+ {"navigation_controller_impl_renderer_did_navigate",
+ crash_keys::kLargeSize},
};
// This dynamic set of keys is used for sets of key value pairs when gathering
« no previous file with comments | « no previous file | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698