Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 2696193006: Use ScopedCrashKey for RendererDidNavigate crash dumps (Closed)
Patch Set: revert unrelated 'git cl format' changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 { "aci_wrong_sp_extension_id", kSmallSize }, 242 { "aci_wrong_sp_extension_id", kSmallSize },
243 243
244 // Temporary for https://crbug.com/616149. 244 // Temporary for https://crbug.com/616149.
245 { "existing_extension_pref_value_type", crash_keys::kSmallSize }, 245 { "existing_extension_pref_value_type", crash_keys::kSmallSize },
246 246
247 // Temporary for https://crbug.com/668633. 247 // Temporary for https://crbug.com/668633.
248 { "swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize }, 248 { "swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize },
249 { "swdh_set_hosted_version_host_pid", crash_keys::kSmallSize }, 249 { "swdh_set_hosted_version_host_pid", crash_keys::kSmallSize },
250 { "swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize }, 250 { "swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize },
251 { "swdh_set_hosted_version_restart_count", crash_keys::kSmallSize }, 251 { "swdh_set_hosted_version_restart_count", crash_keys::kSmallSize },
252
253 // Temporary for https://crbug.com/688425
254 { "navigation_controller_impl_renderer_did_navigate",
255 crash_keys::kLargeSize },
252 }; 256 };
253 257
254 // This dynamic set of keys is used for sets of key value pairs when gathering 258 // This dynamic set of keys is used for sets of key value pairs when gathering
255 // a collection of data, like command line switches or extension IDs. 259 // a collection of data, like command line switches or extension IDs.
256 std::vector<base::debug::CrashKey> keys( 260 std::vector<base::debug::CrashKey> keys(
257 fixed_keys, fixed_keys + arraysize(fixed_keys)); 261 fixed_keys, fixed_keys + arraysize(fixed_keys));
258 262
259 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 263 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
260 264
261 // Register the extension IDs. 265 // Register the extension IDs.
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 } 382 }
379 383
380 ScopedPrinterInfo::~ScopedPrinterInfo() { 384 ScopedPrinterInfo::~ScopedPrinterInfo() {
381 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 385 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
382 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 386 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
383 base::debug::ClearCrashKey(key); 387 base::debug::ClearCrashKey(key);
384 } 388 }
385 } 389 }
386 390
387 } // namespace crash_keys 391 } // namespace crash_keys
OLDNEW
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698