Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2696193006: Use ScopedCrashKey for RendererDidNavigate crash dumps (Closed)
Patch Set: revert unrelated 'git cl format' changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 // browser/: 107 // browser/:
108 {kThirdPartyModulesLoaded, kSmallSize}, 108 {kThirdPartyModulesLoaded, kSmallSize},
109 {kThirdPartyModulesNotLoaded, kSmallSize}, 109 {kThirdPartyModulesNotLoaded, kSmallSize},
110 {kEnrolledToDomain, kSmallSize}, 110 {kEnrolledToDomain, kSmallSize},
111 111
112 // content/: 112 // content/:
113 {"bad_message_reason", kSmallSize}, 113 {"bad_message_reason", kSmallSize},
114 {"discardable-memory-allocated", kSmallSize}, 114 {"discardable-memory-allocated", kSmallSize},
115 {"discardable-memory-free", kSmallSize}, 115 {"discardable-memory-free", kSmallSize},
116 {kFontKeyName, kSmallSize}, 116 {kFontKeyName, kSmallSize},
117 { "mojo-message-error", kMediumSize }, 117 {"mojo-message-error", kMediumSize},
118 {"ppapi_path", kMediumSize}, 118 {"ppapi_path", kMediumSize},
119 {"subresource_url", kLargeSize}, 119 {"subresource_url", kLargeSize},
120 {"total-discardable-memory-allocated", kSmallSize}, 120 {"total-discardable-memory-allocated", kSmallSize},
121 {kBug464926CrashKey, kSmallSize}, 121 {kBug464926CrashKey, kSmallSize},
122 {kViewCount, kSmallSize}, 122 {kViewCount, kSmallSize},
123 {kHungRendererOutstandingAckCount, kSmallSize}, 123 {kHungRendererOutstandingAckCount, kSmallSize},
124 {kHungRendererOutstandingEventType, kSmallSize}, 124 {kHungRendererOutstandingEventType, kSmallSize},
125 {kHungRendererLastEventType, kSmallSize}, 125 {kHungRendererLastEventType, kSmallSize},
126 {kHungRendererReason, kSmallSize}, 126 {kHungRendererReason, kSmallSize},
127 {kInputEventFilterSendFailure, kSmallSize}, 127 {kInputEventFilterSendFailure, kSmallSize},
(...skipping 30 matching lines...) Expand all
158 {"initrf_parent_proxy_exists", kSmallSize}, 158 {"initrf_parent_proxy_exists", kSmallSize},
159 {"initrf_render_view_is_live", kSmallSize}, 159 {"initrf_render_view_is_live", kSmallSize},
160 {"initrf_parent_is_in_same_site_instance", kSmallSize}, 160 {"initrf_parent_is_in_same_site_instance", kSmallSize},
161 {"initrf_parent_process_is_live", kSmallSize}, 161 {"initrf_parent_process_is_live", kSmallSize},
162 {"initrf_root_is_in_same_site_instance", kSmallSize}, 162 {"initrf_root_is_in_same_site_instance", kSmallSize},
163 {"initrf_root_is_in_same_site_instance_as_parent", kSmallSize}, 163 {"initrf_root_is_in_same_site_instance_as_parent", kSmallSize},
164 {"initrf_root_process_is_live", kSmallSize}, 164 {"initrf_root_process_is_live", kSmallSize},
165 {"initrf_root_proxy_is_live", kSmallSize}, 165 {"initrf_root_proxy_is_live", kSmallSize},
166 166
167 // Temporary for https://crbug.com/626802. 167 // Temporary for https://crbug.com/626802.
168 { "newframe_routing_id", kSmallSize }, 168 {"newframe_routing_id", kSmallSize},
169 { "newframe_proxy_id", kSmallSize }, 169 {"newframe_proxy_id", kSmallSize},
170 { "newframe_opener_id", kSmallSize }, 170 {"newframe_opener_id", kSmallSize},
171 { "newframe_parent_id", kSmallSize }, 171 {"newframe_parent_id", kSmallSize},
172 { "newframe_widget_id", kSmallSize }, 172 {"newframe_widget_id", kSmallSize},
173 { "newframe_widget_hidden", kSmallSize }, 173 {"newframe_widget_hidden", kSmallSize},
174 { "newframe_replicated_origin", kSmallSize }, 174 {"newframe_replicated_origin", kSmallSize},
175 { "newframe_oopifs_possible", kSmallSize }, 175 {"newframe_oopifs_possible", kSmallSize},
176 176
177 // Temporary for https://crbug.com/630103. 177 // Temporary for https://crbug.com/630103.
178 { "origin_mismatch_url", crash_keys::kLargeSize }, 178 {"origin_mismatch_url", crash_keys::kLargeSize},
179 { "origin_mismatch_origin", crash_keys::kMediumSize }, 179 {"origin_mismatch_origin", crash_keys::kMediumSize},
180 { "origin_mismatch_transition", crash_keys::kSmallSize }, 180 {"origin_mismatch_transition", crash_keys::kSmallSize},
181 { "origin_mismatch_redirects", crash_keys::kSmallSize }, 181 {"origin_mismatch_redirects", crash_keys::kSmallSize},
182 { "origin_mismatch_same_page", crash_keys::kSmallSize }, 182 {"origin_mismatch_same_page", crash_keys::kSmallSize},
183 183
184 // Temporary for https://crbug.com/612711. 184 // Temporary for https://crbug.com/612711.
185 {"aci_wrong_sp_extension_id", kSmallSize}, 185 {"aci_wrong_sp_extension_id", kSmallSize},
186 186
187 // Temporary for http://crbug.com/621730 187 // Temporary for http://crbug.com/621730
188 {"postmessage_src_origin", kMediumSize}, 188 {"postmessage_src_origin", kMediumSize},
189 {"postmessage_dst_origin", kMediumSize}, 189 {"postmessage_dst_origin", kMediumSize},
190 {"postmessage_dst_url", kLargeSize}, 190 {"postmessage_dst_url", kLargeSize},
191 {"postmessage_script_info", kLargeSize}, 191 {"postmessage_script_info", kLargeSize},
192 192
193 // Temporary for https://crbug.com/616149. 193 // Temporary for https://crbug.com/616149.
194 {"existing_extension_pref_value_type", crash_keys::kSmallSize}, 194 {"existing_extension_pref_value_type", crash_keys::kSmallSize},
195 195
196 // Temporary for https://crbug.com/668633. 196 // Temporary for https://crbug.com/668633.
197 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize}, 197 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize},
198 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize}, 198 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize},
199 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize}, 199 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize},
200 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize}, 200 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize},
201
202 // Temporary for https://crbug.com/688425
203 {"navigation_controller_impl_renderer_did_navigate",
204 crash_keys::kLargeSize},
201 }; 205 };
202 206
203 // This dynamic set of keys is used for sets of key value pairs when gathering 207 // This dynamic set of keys is used for sets of key value pairs when gathering
204 // a collection of data, like command line switches or extension IDs. 208 // a collection of data, like command line switches or extension IDs.
205 std::vector<base::debug::CrashKey> keys(fixed_keys, 209 std::vector<base::debug::CrashKey> keys(fixed_keys,
206 fixed_keys + arraysize(fixed_keys)); 210 fixed_keys + arraysize(fixed_keys));
207 211
208 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 212 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
209 213
210 // Register the extension IDs. 214 // Register the extension IDs.
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 403 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
400 return install_static::GetCollectStatsInSample(); 404 return install_static::GetCollectStatsInSample();
401 } 405 }
402 406
403 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 407 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
404 const std::string& process_type) { 408 const std::string& process_type) {
405 // This is not used by Crashpad (at least on Windows). 409 // This is not used by Crashpad (at least on Windows).
406 NOTREACHED(); 410 NOTREACHED();
407 return true; 411 return true;
408 } 412 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698