Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2696193006: Use ScopedCrashKey for RendererDidNavigate crash dumps (Closed)
Patch Set: revert unrelated 'git cl format' changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 164fafe7203ad9b31eb6c63b98d21bb384f4fe95..7daa46f99106e1922ed9757feb41d88384118679 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -40,6 +40,7 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "base/debug/alias.h"
+#include "base/debug/crash_logging.h"
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
@@ -187,10 +188,13 @@ void MaybeDumpCopiedNonSameOriginEntry(
std::string(params.should_replace_current_entry
? "should replace current entry, "
: "should not replace current entry, ") +
+ std::string(params.intended_as_new_entry
+ ? "intended as new entry, "
+ : "not intended as new entry, ") +
+ std::string(params.url_is_unreachable ? "URL is unreachable, " : "") +
entry->GetURL().spec() + " -> " + params.url.spec();
- char debug_buf[2000];
- base::strlcpy(debug_buf, debug_info.c_str(), arraysize(debug_buf));
- base::debug::Alias(&debug_buf);
+ base::debug::ScopedCrashKey crash_key(
+ "navigation_controller_impl_renderer_did_navigate", debug_info);
base::debug::DumpWithoutCrashing();
}
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698