Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2692313002: Reland of nable SecurityTest.NewOverflow on Windows, with clang fix (Closed)

Created:
3 years, 10 months ago by Nico
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, Will Harris
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of nable SecurityTest.NewOverflow on Windows, with clang fix (patchset #1 id:1 of https://codereview.chromium.org/2692183002/ ) Reason for revert: Reland with test disabled on ASan. Original issue's description: > Revert of Reenable SecurityTest.NewOverflow on Windows, with clang fix (patchset #2 id:20001 of https://codereview.chromium.org/2694873002/ ) > > Reason for revert: > This causes failures in the Mac ASAN bots: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29 > > Original issue's description: > > Reenable SecurityTest.NewOverflow on Windows, with clang fix > > > > Relands https://codereview.chromium.org/2679153002 with a fix for clang. > > > > BUG=690271 > > > > Review-Url: https://codereview.chromium.org/2694873002 > > Cr-Commit-Position: refs/heads/master@{#450098} > > Committed: https://chromium.googlesource.com/chromium/src/+/9b14da5b9f4f5c2b78bc1b64fa590e126f0f2866 > > TBR=siggi@chromium.org,thakis@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=690271 > > Review-Url: https://codereview.chromium.org/2692183002 > Cr-Commit-Position: refs/heads/master@{#450166} > Committed: https://chromium.googlesource.com/chromium/src/+/906ce688ee9742245387dd42581020c905ab0e86 TBR=siggi@chromium.org,gcasto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=690271 Review-Url: https://codereview.chromium.org/2692313002 Cr-Commit-Position: refs/heads/master@{#450375} Committed: https://chromium.googlesource.com/chromium/src/+/4d7b56b40717cfe0d41f7f11de12b024a1dd6fca

Patch Set 1 #

Patch Set 2 : no asan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M base/security_unittest.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Nico
Created Reland of nable SecurityTest.NewOverflow on Windows, with clang fix
3 years, 10 months ago (2017-02-14 16:17:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692313002/40001
3 years, 10 months ago (2017-02-14 16:21:01 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 16:22:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4d7b56b40717cfe0d41f7f11de12...

Powered by Google App Engine
This is Rietveld 408576698