Reenable SecurityTest.NewOverflow on Windows, with clang fix

Reenable SecurityTest.NewOverflow on Windows, with clang fix

Relands https://codereview.chromium.org/2679153002 with a fix for clang.

BUG=690271
Review-Url: https://codereview.chromium.org/2694873002
Cr-Commit-Position: refs/heads/master@{#450098}
Committed: https://chromium.googlesource.com/chromium/src/+/9b14da5b9f4f5c2b78bc1b64fa590e126f0f2866

[Nico, 2017-02-13 18:59:49]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-02-13 19:00:15]

thakis@chromium.org changed reviewers:
+ siggi@chromium.org

[commit-bot: I haz the power, 2017-02-13 19:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-13 19:00:15]

https://codereview.chromium.org/2694873002/diff/1/base/security_unittest.cc
File base/security_unittest.cc (left):

https://codereview.chromium.org/2694873002/diff/1/base/security_unittest.cc#o...
base/security_unittest.cc:106: // use an ugly cast.
unrelated, but while here i did this too

[commit-bot: I haz the power, 2017-02-13 19:07:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 19:07:06]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sigurður Ásgeirsson, 2017-02-13 19:14:34]

lgtm

https://codereview.chromium.org/2694873002/diff/1/base/security_unittest.cc
File base/security_unittest.cc (right):

https://codereview.chromium.org/2694873002/diff/1/base/security_unittest.cc#n...
base/security_unittest.cc:111: char* volatile p =
reinterpret_cast<char*>(array_pointer.get());
Ah - that's where the volatile applies. In stolen moments on Friday I tried
making the integers volatile :/.
So casting an allocated pointer to volatile works around the the
malloc()-eliding?

[Nico, 2017-02-13 20:42:11]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 20:43:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-13 20:47:59]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-02-13 20:48:01]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-02-13 20:48:02]

The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org
Link to the patchset: https://codereview.chromium.org/2694873002/#ps20001
(title: "durr")

[commit-bot: I haz the power, 2017-02-13 20:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 21:31:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487018881761000,
"parent_rev": "a2665e010b198f117ab5bc9fcf60f7aa02b92f67", "commit_rev":
"9b14da5b9f4f5c2b78bc1b64fa590e126f0f2866"}

[commit-bot: I haz the power, 2017-02-13 21:31:59]

Description was changed from

==========
Reenable SecurityTest.NewOverflow on Windows, with clang fix

Relands https://codereview.chromium.org/2679153002 with a fix for clang.

BUG=690271
==========

to

==========
Reenable SecurityTest.NewOverflow on Windows, with clang fix

Relands https://codereview.chromium.org/2679153002 with a fix for clang.

BUG=690271

Review-Url: https://codereview.chromium.org/2694873002
Cr-Commit-Position: refs/heads/master@{#450098}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b14da5b9f4f5c2b78bc1b64fa59...
==========

[commit-bot: I haz the power, 2017-02-13 21:32:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9b14da5b9f4f5c2b78bc1b64fa59...

[Garrett Casto, 2017-02-14 00:08:34]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2692183002/ by gcasto@chromium.org.

The reason for reverting is: This causes failures in the Mac ASAN bots:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20....