Re-enable SecurityTest.NewOverFlow on Windows.

Re-enable SecurityTest.NewOverFlow on Windows.

BUG=

Review-Url: https://codereview.chromium.org/2679153002
Cr-Commit-Position: refs/heads/master@{#449041}
Committed: https://chromium.googlesource.com/chromium/src/+/82681d8ead6aa059caf6a64e485dbc6b210339be

[Sigurður Ásgeirsson, 2017-02-07 15:16:17]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 15:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 15:51:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 15:51:21]

Dry run: This issue passed the CQ dry run.

[Will Harris, 2017-02-07 16:26:15]

seems this was disabled because "crashes on windows debug builds"

https://chromiumcodereview.appspot.com/13600003

Have you confirmed this works now on debug builds, otherwise it's likely the
waterfall will go red.

[Will Harris, 2017-02-07 16:26:23]

Description was changed from

==========
Re-enable SecurityTest.NewOverFlow on Windows.

BUG=
==========

to

==========
Re-enable SecurityTest.NewOverFlow on Windows.

BUG=
==========

[Will Harris, 2017-02-07 16:26:23]

wfh@chromium.org changed reviewers:
+ wfh@chromium.org

[Sigurður Ásgeirsson, 2017-02-07 16:29:47]

Good point - pushed it at our *win*_dbg try servers. IMHO would make sense
to enable for release configs at least, to prevent regressions in our
shimming gunk.

On Tue, Feb 7, 2017 at 11:26 AM <wfh@chromium.org> wrote:

> seems this was disabled because "crashes on windows debug builds"
>
> https://chromiumcodereview.appspot.com/13600003
>
> Have you confirmed this works now on debug builds, otherwise it's likely
> the
> waterfall will go red.
>
> https://codereview.chromium.org/2679153002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sigurður Ásgeirsson, 2017-02-07 16:52:11]

Looks like they're passing in debug:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2...

On Tue, Feb 7, 2017 at 11:29 AM Sigurður Ásgeirsson <siggi@chromium.org>
wrote:

> Good point - pushed it at our *win*_dbg try servers. IMHO would make sense
> to enable for release configs at least, to prevent regressions in our
> shimming gunk.
>
> On Tue, Feb 7, 2017 at 11:26 AM <wfh@chromium.org> wrote:
>
> seems this was disabled because "crashes on windows debug builds"
>
> https://chromiumcodereview.appspot.com/13600003
>
> Have you confirmed this works now on debug builds, otherwise it's likely
> the
> waterfall will go red.
>
> https://codereview.chromium.org/2679153002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sigurður Ásgeirsson, 2017-02-07 19:31:10]

siggi@chromium.org changed reviewers:
+ gab@chromium.org

[Sigurður Ásgeirsson, 2017-02-07 19:31:10]

Hey Will, this appears to not crash our debug builds that I can see (ran the
*deb_* trybots).
Gab for OWNERS please?

[gab, 2017-02-07 19:37:28]

AFAIK we no longer have debug configurations on the waterfall?

But if Will is happy, I'm always fine with re-enabling tests, so r-s lgtm

https://codereview.chromium.org/2679153002/diff/1/base/security_unittest.cc
File base/security_unittest.cc (right):

https://codereview.chromium.org/2679153002/diff/1/base/security_unittest.cc#n...
base/security_unittest.cc:97: // Crashes on Windows Dbg builds, disable there as
well.
Update comment.

[Will Harris, 2017-02-07 23:26:04]

I'm fine with this lgtm, but watch the tree :)

[Sigurður Ásgeirsson, 2017-02-08 18:27:40]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2017-02-08 18:28:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 18:42:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486578460548800, "parent_rev":
"f8ac642ad2d6c45b0a6d293e753997bcb03470cd", "commit_rev":
"82681d8ead6aa059caf6a64e485dbc6b210339be"}

[Sigurður Ásgeirsson, 2017-02-08 18:42:51]

The CQ bit was unchecked by siggi@chromium.org

[commit-bot: I haz the power, 2017-02-08 18:43:22]

Description was changed from

==========
Re-enable SecurityTest.NewOverFlow on Windows.

BUG=
==========

to

==========
Re-enable SecurityTest.NewOverFlow on Windows.

BUG=

Review-Url: https://codereview.chromium.org/2679153002
Cr-Commit-Position: refs/heads/master@{#449041}
Committed:
https://chromium.googlesource.com/chromium/src/+/82681d8ead6aa059caf6a64e485d...
==========

[commit-bot: I haz the power, 2017-02-08 18:43:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82681d8ead6aa059caf6a64e485d...

[Sigurður Ásgeirsson, 2017-02-08 18:45:40]

Thanks.

https://codereview.chromium.org/2679153002/diff/1/base/security_unittest.cc
File base/security_unittest.cc (right):

https://codereview.chromium.org/2679153002/diff/1/base/security_unittest.cc#n...
base/security_unittest.cc:97: // Crashes on Windows Dbg builds, disable there as
well.
On 2017/02/07 19:37:28, gab wrote:
> Update comment.

Done.

[Sigurður Ásgeirsson, 2017-02-08 18:46:08]

Patchset #2 (id:20001) has been deleted

[Nico, 2017-02-10 22:57:36]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2691543003/ by thakis@chromium.org.

The reason for reverting is: Broke all the clang/win bots
(https://crbug.com/690271), and I'd like to have them clear for the weekend.
Easy to reland..