Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2692183002: Revert of Reenable SecurityTest.NewOverflow on Windows, with clang fix (Closed)

Created:
3 years, 10 months ago by Garrett Casto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, Will Harris
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable SecurityTest.NewOverflow on Windows, with clang fix (patchset #2 id:20001 of https://codereview.chromium.org/2694873002/ ) Reason for revert: This causes failures in the Mac ASAN bots: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29 Original issue's description: > Reenable SecurityTest.NewOverflow on Windows, with clang fix > > Relands https://codereview.chromium.org/2679153002 with a fix for clang. > > BUG=690271 > > Review-Url: https://codereview.chromium.org/2694873002 > Cr-Commit-Position: refs/heads/master@{#450098} > Committed: https://chromium.googlesource.com/chromium/src/+/9b14da5b9f4f5c2b78bc1b64fa590e126f0f2866 TBR=siggi@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=690271 Review-Url: https://codereview.chromium.org/2692183002 Cr-Commit-Position: refs/heads/master@{#450166} Committed: https://chromium.googlesource.com/chromium/src/+/906ce688ee9742245387dd42581020c905ab0e86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M base/security_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Garrett Casto
Created Revert of Reenable SecurityTest.NewOverflow on Windows, with clang fix
3 years, 10 months ago (2017-02-14 00:08:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692183002/1
3 years, 10 months ago (2017-02-14 00:09:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/906ce688ee9742245387dd42581020c905ab0e86
3 years, 10 months ago (2017-02-14 00:11:27 UTC) #6
Nico
Can you paste the failure or link to a public bot? On Feb 13, 2017 ...
3 years, 10 months ago (2017-02-14 00:14:18 UTC) #7
Garrett Casto
Does the link that I gave in the revert reason not work? Bot is: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29 ...
3 years, 10 months ago (2017-02-14 00:21:04 UTC) #8
Nico
That's not a public bot. I can't look at that from my off Corp laptop. ...
3 years, 10 months ago (2017-02-14 03:01:56 UTC) #9
Nico
public link: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/27082
3 years, 10 months ago (2017-02-14 16:17:06 UTC) #10
Nico
3 years, 10 months ago (2017-02-14 16:17:19 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2692313002/ by thakis@chromium.org.

The reason for reverting is: Reland with test disabled on ASan..

Powered by Google App Engine
This is Rietveld 408576698