Removed fields from Selection classes

Removed fields from Selection classes

Landing crrev.com/2201853002 made the |is_editable| and |is_empty_text_form_control| fields unnecessary. This CL removes them.

BUG=633281
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2691583003
Cr-Commit-Position: refs/heads/master@{#451357}
Committed: https://chromium.googlesource.com/chromium/src/+/d9d34e59b180cb66b27b3bc28a61ce1ef6728db3

[amaralp, 2017-02-10 20:34:27]

Description was changed from

==========
Removed fields from Selection classes

BUG=
==========

to

==========
Removed fields from Selection classes

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[amaralp, 2017-02-10 20:34:28]

Description was changed from

==========
Removed fields from Selection classes

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Removed fields from Selection classes

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[amaralp, 2017-02-10 20:34:34]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 20:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 20:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 20:56:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[amaralp, 2017-02-10 21:46:21]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 21:47:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 01:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 01:28:54]

Dry run: This issue passed the CQ dry run.

[amaralp, 2017-02-11 02:04:23]

Description was changed from

==========
Removed fields from Selection classes

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Removed fields from Selection classes

Landing crrev.com/2201853002 made the is_editable and fields unnecessary. This
CL removes them.

BUG=633281

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[amaralp, 2017-02-11 02:04:23]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org

[amaralp, 2017-02-11 02:13:33]

Description was changed from

==========
Removed fields from Selection classes

Landing crrev.com/2201853002 made the is_editable and fields unnecessary. This
CL removes them.

BUG=633281

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Removed fields from Selection classes

Landing crrev.com/2201853002 made the |is_editable| and
|is_empty_text_form_control| fields unnecessary. This CL removes them.

BUG=633281

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[amaralp, 2017-02-11 02:16:18]

PTAL

[aelias_OOO_until_Jul13, 2017-02-11 06:42:34]

lgtm, thanks for the cleanup!

[amaralp, 2017-02-11 23:30:22]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2017-02-11 23:30:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 23:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 23:37:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[amaralp, 2017-02-13 21:12:28]

aelias@, it looks I'm missing OWNER for cc/ipc. Does your lgtm not count for
that?

[aelias_OOO_until_Jul13, 2017-02-14 01:25:17]

aelias@chromium.org changed reviewers:
+ tsepez@chromium.org

[aelias_OOO_until_Jul13, 2017-02-14 01:25:18]

No, because of:
per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS

Adding tsepez@ for security OWNERS.

[Tom Sepez, 2017-02-14 18:06:26]

RS LGTM on deleting members.

[amaralp, 2017-02-14 19:06:13]

amaralp@chromium.org changed reviewers:
+ bokan@chromium.org, wangxianzhu@chromium.org

[amaralp, 2017-02-14 19:06:14]

Adding bokan@ for core/frame OWNERS and wangxianzhu@ for core/layout OWNERS.

[Xianzhu, 2017-02-14 19:09:26]

core/layout lgtm.

[amaralp, 2017-02-16 21:38:57]

amaralp@chromium.org changed reviewers:
+ dcheng@chromium.org
- bokan@chromium.org

[amaralp, 2017-02-16 21:38:58]

Adding dcheng@ for core/frame OWNERS

[dcheng, 2017-02-16 21:41:34]

rs lgtm for core/frame

[amaralp, 2017-02-16 21:57:57]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:59:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 23:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 23:42:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[amaralp, 2017-02-17 00:17:40]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:18:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:02:01]

The CQ bit was unchecked by commit-bot@chromium.org

[amaralp, 2017-02-17 19:04:25]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:05:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:51:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487358265223730,
"parent_rev": "ab00bb3e38a097b8e8362fe66d7f62fe82182a81", "commit_rev":
"d9d34e59b180cb66b27b3bc28a61ce1ef6728db3"}

[commit-bot: I haz the power, 2017-02-17 19:51:55]

Description was changed from

==========
Removed fields from Selection classes

Landing crrev.com/2201853002 made the |is_editable| and
|is_empty_text_form_control| fields unnecessary. This CL removes them.

BUG=633281

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Removed fields from Selection classes

Landing crrev.com/2201853002 made the |is_editable| and
|is_empty_text_form_control| fields unnecessary. This CL removes them.

BUG=633281

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2691583003
Cr-Commit-Position: refs/heads/master@{#451357}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9d34e59b180cb66b27b3bc28a61...
==========

[commit-bot: I haz the power, 2017-02-17 19:51:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9d34e59b180cb66b27b3bc28a61...