Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2691583003: Removed fields from Selection classes (Closed)
Patch Set: Forgot to remove fields from test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1983 matching lines...) Expand 10 before | Expand all | Expand 10 after
1994 if (!selection.start.layer) 1994 if (!selection.start.layer)
1995 return false; 1995 return false;
1996 1996
1997 VisiblePosition visibleEnd(visibleSelection.visibleEnd()); 1997 VisiblePosition visibleEnd(visibleSelection.visibleEnd());
1998 RenderedPosition renderedEnd(visibleEnd); 1998 RenderedPosition renderedEnd(visibleEnd);
1999 renderedEnd.positionInGraphicsLayerBacking(selection.end, false); 1999 renderedEnd.positionInGraphicsLayerBacking(selection.end, false);
2000 if (!selection.end.layer) 2000 if (!selection.end.layer)
2001 return false; 2001 return false;
2002 2002
2003 selection.type = visibleSelection.getSelectionType(); 2003 selection.type = visibleSelection.getSelectionType();
2004 selection.isEditable = visibleSelection.isContentEditable();
2005 if (selection.isEditable) {
2006 if (TextControlElement* enclosingTextControlElement =
2007 enclosingTextControl(visibleSelection.rootEditableElement())) {
2008 selection.isEmptyTextControl =
2009 enclosingTextControlElement->value().isEmpty();
2010 }
2011 }
2012 selection.start.isTextDirectionRTL |= 2004 selection.start.isTextDirectionRTL |=
2013 primaryDirectionOf(*visibleSelection.start().anchorNode()) == 2005 primaryDirectionOf(*visibleSelection.start().anchorNode()) ==
2014 TextDirection::kRtl; 2006 TextDirection::kRtl;
2015 selection.end.isTextDirectionRTL |= 2007 selection.end.isTextDirectionRTL |=
2016 primaryDirectionOf(*visibleSelection.end().anchorNode()) == 2008 primaryDirectionOf(*visibleSelection.end().anchorNode()) ==
2017 TextDirection::kRtl; 2009 TextDirection::kRtl;
2018 2010
2019 return true; 2011 return true;
2020 } 2012 }
2021 2013
(...skipping 3123 matching lines...) Expand 10 before | Expand all | Expand 10 after
5145 std::unique_ptr<CompositorAnimationTimeline> timeline) { 5137 std::unique_ptr<CompositorAnimationTimeline> timeline) {
5146 m_animationTimeline = std::move(timeline); 5138 m_animationTimeline = std::move(timeline);
5147 } 5139 }
5148 5140
5149 void FrameView::setAnimationHost( 5141 void FrameView::setAnimationHost(
5150 std::unique_ptr<CompositorAnimationHost> host) { 5142 std::unique_ptr<CompositorAnimationHost> host) {
5151 m_animationHost = std::move(host); 5143 m_animationHost = std::move(host);
5152 } 5144 }
5153 5145
5154 } // namespace blink 5146 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698