Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2641)

Unified Diff: cc/ipc/struct_traits_unittest.cc

Issue 2691583003: Removed fields from Selection classes (Closed)
Patch Set: Forgot to remove fields from test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/ipc/selection_struct_traits.h ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/struct_traits_unittest.cc
diff --git a/cc/ipc/struct_traits_unittest.cc b/cc/ipc/struct_traits_unittest.cc
index 5d22e492c579dd577f6d3141de592f2a9663a9d4..e8cff2b693a369b72805878f7dfebb4a782e4c12 100644
--- a/cc/ipc/struct_traits_unittest.cc
+++ b/cc/ipc/struct_traits_unittest.cc
@@ -297,8 +297,6 @@ TEST_F(StructTraitsTest, CompositorFrameMetadata) {
gfx::PointF(1234.3f, 8765.6f));
selection.end.set_visible(false);
selection.end.set_type(gfx::SelectionBound::RIGHT);
- selection.is_editable = true;
- selection.is_empty_text_form_control = true;
ui::LatencyInfo latency_info;
latency_info.AddLatencyNumber(
ui::LATENCY_BEGIN_SCROLL_LISTENER_UPDATE_MAIN_COMPONENT, 1337, 7331);
@@ -845,20 +843,14 @@ TEST_F(StructTraitsTest, Selection) {
end.SetEdge(gfx::PointF(1337.5f, 52124.f), gfx::PointF(1234.3f, 8765.6f));
end.set_visible(false);
end.set_type(gfx::SelectionBound::RIGHT);
- const bool is_editable = true;
- const bool is_empty_text_form_control = true;
Selection<gfx::SelectionBound> input;
input.start = start;
input.end = end;
- input.is_editable = is_editable;
- input.is_empty_text_form_control = is_empty_text_form_control;
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
Selection<gfx::SelectionBound> output;
proxy->EchoSelection(input, &output);
EXPECT_EQ(start, output.start);
EXPECT_EQ(end, output.end);
- EXPECT_EQ(is_editable, output.is_editable);
- EXPECT_EQ(is_empty_text_form_control, output.is_empty_text_form_control);
}
TEST_F(StructTraitsTest, SurfaceId) {
« no previous file with comments | « cc/ipc/selection_struct_traits.h ('k') | cc/trees/layer_tree_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698