Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: cc/ipc/selection_struct_traits.h

Issue 2691583003: Removed fields from Selection classes (Closed)
Patch Set: Forgot to remove fields from test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/ipc/selection.mojom ('k') | cc/ipc/struct_traits_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_IPC_SELECTION_STRUCT_TRAITS_H_ 5 #ifndef CC_IPC_SELECTION_STRUCT_TRAITS_H_
6 #define CC_IPC_SELECTION_STRUCT_TRAITS_H_ 6 #define CC_IPC_SELECTION_STRUCT_TRAITS_H_
7 7
8 #include "cc/input/selection.h" 8 #include "cc/input/selection.h"
9 #include "cc/ipc/selection.mojom-shared.h" 9 #include "cc/ipc/selection.mojom-shared.h"
10 10
11 namespace mojo { 11 namespace mojo {
12 12
13 template <> 13 template <>
14 struct StructTraits<cc::mojom::SelectionDataView, 14 struct StructTraits<cc::mojom::SelectionDataView,
15 cc::Selection<gfx::SelectionBound>> { 15 cc::Selection<gfx::SelectionBound>> {
16 static const gfx::SelectionBound& start( 16 static const gfx::SelectionBound& start(
17 const cc::Selection<gfx::SelectionBound>& selection) { 17 const cc::Selection<gfx::SelectionBound>& selection) {
18 return selection.start; 18 return selection.start;
19 } 19 }
20 20
21 static const gfx::SelectionBound& end( 21 static const gfx::SelectionBound& end(
22 const cc::Selection<gfx::SelectionBound>& selection) { 22 const cc::Selection<gfx::SelectionBound>& selection) {
23 return selection.end; 23 return selection.end;
24 } 24 }
25 25
26 static bool is_editable(const cc::Selection<gfx::SelectionBound>& selection) {
27 return selection.is_editable;
28 }
29
30 static bool is_empty_text_form_control(
31 const cc::Selection<gfx::SelectionBound>& selection) {
32 return selection.is_empty_text_form_control;
33 }
34
35 static bool Read(cc::mojom::SelectionDataView data, 26 static bool Read(cc::mojom::SelectionDataView data,
36 cc::Selection<gfx::SelectionBound>* out) { 27 cc::Selection<gfx::SelectionBound>* out) {
37 if (!data.ReadStart(&out->start) || !data.ReadEnd(&out->end)) 28 return data.ReadStart(&out->start) && data.ReadEnd(&out->end);
38 return false;
39
40 out->is_editable = data.is_editable();
41 out->is_empty_text_form_control = data.is_empty_text_form_control();
42 return true;
43 } 29 }
44 }; 30 };
45 31
46 } // namespace mojo 32 } // namespace mojo
47 33
48 #endif // CC_IPC_SELECTION_STRUCT_TRAITS_H_ 34 #endif // CC_IPC_SELECTION_STRUCT_TRAITS_H_
OLDNEW
« no previous file with comments | « cc/ipc/selection.mojom ('k') | cc/ipc/struct_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698