Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2691583003: Removed fields from Selection classes (Closed)
Patch Set: Forgot to remove fields from test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 62fef414a6f1da0f9bd3973152b15031c08db376..23629a175bc267c07a5186194992caf9ba2b6d37 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2001,14 +2001,6 @@ bool FrameView::computeCompositedSelection(LocalFrame& frame,
return false;
selection.type = visibleSelection.getSelectionType();
- selection.isEditable = visibleSelection.isContentEditable();
- if (selection.isEditable) {
- if (TextControlElement* enclosingTextControlElement =
- enclosingTextControl(visibleSelection.rootEditableElement())) {
- selection.isEmptyTextControl =
- enclosingTextControlElement->value().isEmpty();
- }
- }
selection.start.isTextDirectionRTL |=
primaryDirectionOf(*visibleSelection.start().anchorNode()) ==
TextDirection::kRtl;

Powered by Google App Engine
This is Rietveld 408576698