Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2687013003: Revert of [debugger] expose side-effect free evaluate to inspector. (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
Reviewers:
kozy, pfeldman, Yang, jgruber
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] expose side-effect free evaluate to inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2685483002/ ) Reason for revert: Speculative revert. Seems to block the roll: https://codereview.chromium.org/2685933005/ Original issue's description: > [debugger] expose side-effect free evaluate to inspector. > > R=jgruber@chromium.org, kozyatinskiy@chromium.org > BUG=v8:5821 > > Review-Url: https://codereview.chromium.org/2685483002 > Cr-Commit-Position: refs/heads/master@{#43049} > Committed: https://chromium.googlesource.com/v8/v8/+/1a989bdeefdc679745215ae547007773edb3d29e TBR=jgruber@chromium.org,kozyatinskiy@chromium.org,pfeldman@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5821 Review-Url: https://codereview.chromium.org/2687013003 Cr-Commit-Position: refs/heads/master@{#43060} Committed: https://chromium.googlesource.com/v8/v8/+/3186653665ccf618de48868337a43abbe5b894a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -56 lines) Patch
M src/debug/debug-evaluate.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/debug/debug-evaluate.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +2 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/inspector/debugger-script.js View 1 chunk +3 lines, -4 lines 0 comments Download
M src/inspector/debugger_script_externs.js View 2 chunks +3 lines, -4 lines 0 comments Download
M src/inspector/java-script-call-frame.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/java-script-call-frame.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/inspector/js_protocol.json View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M test/debugger/debug/debug-evaluate-no-side-effect.js View 2 chunks +3 lines, -5 lines 0 comments Download
M test/debugger/debug/debug-evaluate-no-side-effect-builtins.js View 2 chunks +3 lines, -5 lines 0 comments Download
M test/debugger/test-api.js View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [debugger] expose side-effect free evaluate to inspector.
3 years, 10 months ago (2017-02-09 11:49:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687013003/1
3 years, 10 months ago (2017-02-09 11:49:25 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 11:49:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3186653665ccf618de48868337a43abbe5b...

Powered by Google App Engine
This is Rietveld 408576698