Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 2687013003: Revert of [debugger] expose side-effect free evaluate to inspector. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | test/debugger/debug/debug-evaluate-no-side-effect.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/debug/debug-evaluate.h" 9 #include "src/debug/debug-evaluate.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 1186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 isolate->debug()->ClearStepping(); 1197 isolate->debug()->ClearStepping();
1198 return isolate->heap()->undefined_value(); 1198 return isolate->heap()->undefined_value();
1199 } 1199 }
1200 1200
1201 1201
1202 RUNTIME_FUNCTION(Runtime_DebugEvaluate) { 1202 RUNTIME_FUNCTION(Runtime_DebugEvaluate) {
1203 HandleScope scope(isolate); 1203 HandleScope scope(isolate);
1204 1204
1205 // Check the execution state and decode arguments frame and source to be 1205 // Check the execution state and decode arguments frame and source to be
1206 // evaluated. 1206 // evaluated.
1207 DCHECK_EQ(5, args.length()); 1207 DCHECK_EQ(4, args.length());
1208 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]); 1208 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]);
1209 CHECK(isolate->debug()->CheckExecutionState(break_id)); 1209 CHECK(isolate->debug()->CheckExecutionState(break_id));
1210 1210
1211 CONVERT_SMI_ARG_CHECKED(wrapped_id, 1); 1211 CONVERT_SMI_ARG_CHECKED(wrapped_id, 1);
1212 CONVERT_NUMBER_CHECKED(int, inlined_jsframe_index, Int32, args[2]); 1212 CONVERT_NUMBER_CHECKED(int, inlined_jsframe_index, Int32, args[2]);
1213 CONVERT_ARG_HANDLE_CHECKED(String, source, 3); 1213 CONVERT_ARG_HANDLE_CHECKED(String, source, 3);
1214 CONVERT_BOOLEAN_ARG_CHECKED(throw_on_side_effect, 4);
1215 1214
1216 StackFrame::Id id = DebugFrameHelper::UnwrapFrameId(wrapped_id); 1215 StackFrame::Id id = DebugFrameHelper::UnwrapFrameId(wrapped_id);
1217 1216
1218 RETURN_RESULT_OR_FAILURE( 1217 RETURN_RESULT_OR_FAILURE(
1219 isolate, DebugEvaluate::Local(isolate, id, inlined_jsframe_index, source, 1218 isolate,
1220 throw_on_side_effect)); 1219 DebugEvaluate::Local(isolate, id, inlined_jsframe_index, source));
1221 } 1220 }
1222 1221
1223 1222
1224 RUNTIME_FUNCTION(Runtime_DebugEvaluateGlobal) { 1223 RUNTIME_FUNCTION(Runtime_DebugEvaluateGlobal) {
1225 HandleScope scope(isolate); 1224 HandleScope scope(isolate);
1226 1225
1227 // Check the execution state and decode arguments frame and source to be 1226 // Check the execution state and decode arguments frame and source to be
1228 // evaluated. 1227 // evaluated.
1229 DCHECK_EQ(2, args.length()); 1228 DCHECK_EQ(2, args.length());
1230 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]); 1229 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]);
(...skipping 656 matching lines...) Expand 10 before | Expand all | Expand 10 after
1887 } 1886 }
1888 1887
1889 1888
1890 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1889 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1891 UNIMPLEMENTED(); 1890 UNIMPLEMENTED();
1892 return NULL; 1891 return NULL;
1893 } 1892 }
1894 1893
1895 } // namespace internal 1894 } // namespace internal
1896 } // namespace v8 1895 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | test/debugger/debug/debug-evaluate-no-side-effect.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698