Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2407)

Unified Diff: src/inspector/debugger_script_externs.js

Issue 2687013003: Revert of [debugger] expose side-effect free evaluate to inspector. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/debugger-script.js ('k') | src/inspector/java-script-call-frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/debugger_script_externs.js
diff --git a/src/inspector/debugger_script_externs.js b/src/inspector/debugger_script_externs.js
index 6289937f25a6d7114567f28bc7fa06c77531328c..c1c45c756c8b60437bcfb5b83c76809f45e763b1 100644
--- a/src/inspector/debugger_script_externs.js
+++ b/src/inspector/debugger_script_externs.js
@@ -31,7 +31,7 @@
/** @typedef {{
contextId: function():number,
thisObject: !Object,
- evaluate: function(string, boolean):*,
+ evaluate: function(string):*,
restart: function():undefined,
setVariableValue: function(number, string, *):undefined,
isAtReturn: boolean,
@@ -360,9 +360,8 @@
/**
* @param {string} source
- * @param {boolean} throwOnSideEffect
- */
-FrameMirror.prototype.evaluate = function(source, throwOnSideEffect) {}
+ */
+FrameMirror.prototype.evaluate = function(source) {}
FrameMirror.prototype.restart = function() {}
« no previous file with comments | « src/inspector/debugger-script.js ('k') | src/inspector/java-script-call-frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698