Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/inspector/java-script-call-frame.h

Issue 2687013003: Revert of [debugger] expose side-effect free evaluate to inspector. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | src/inspector/java-script-call-frame.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 return std::unique_ptr<JavaScriptCallFrame>( 47 return std::unique_ptr<JavaScriptCallFrame>(
48 new JavaScriptCallFrame(debuggerContext, callFrame)); 48 new JavaScriptCallFrame(debuggerContext, callFrame));
49 } 49 }
50 ~JavaScriptCallFrame(); 50 ~JavaScriptCallFrame();
51 51
52 int contextId() const; 52 int contextId() const;
53 53
54 bool isAtReturn() const; 54 bool isAtReturn() const;
55 v8::MaybeLocal<v8::Object> details() const; 55 v8::MaybeLocal<v8::Object> details() const;
56 56
57 v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression, 57 v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression);
58 bool throwOnSideEffect);
59 v8::MaybeLocal<v8::Value> restart(); 58 v8::MaybeLocal<v8::Value> restart();
60 v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber, 59 v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber,
61 v8::Local<v8::Value> variableName, 60 v8::Local<v8::Value> variableName,
62 v8::Local<v8::Value> newValue); 61 v8::Local<v8::Value> newValue);
63 62
64 private: 63 private:
65 JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext, 64 JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext,
66 v8::Local<v8::Object> callFrame); 65 v8::Local<v8::Object> callFrame);
67 66
68 int callV8FunctionReturnInt(const char* name) const; 67 int callV8FunctionReturnInt(const char* name) const;
69 68
70 v8::Isolate* m_isolate; 69 v8::Isolate* m_isolate;
71 v8::Global<v8::Context> m_debuggerContext; 70 v8::Global<v8::Context> m_debuggerContext;
72 v8::Global<v8::Object> m_callFrame; 71 v8::Global<v8::Object> m_callFrame;
73 72
74 DISALLOW_COPY_AND_ASSIGN(JavaScriptCallFrame); 73 DISALLOW_COPY_AND_ASSIGN(JavaScriptCallFrame);
75 }; 74 };
76 75
77 using JavaScriptCallFrames = std::vector<std::unique_ptr<JavaScriptCallFrame>>; 76 using JavaScriptCallFrames = std::vector<std::unique_ptr<JavaScriptCallFrame>>;
78 77
79 } // namespace v8_inspector 78 } // namespace v8_inspector
80 79
81 #endif // V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_ 80 #endif // V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_
OLDNEW
« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | src/inspector/java-script-call-frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698