Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: test/debugger/test-api.js

Issue 2687013003: Revert of [debugger] expose side-effect free evaluate to inspector. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/debugger/debug/debug-evaluate-no-side-effect-builtins.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/debugger/test-api.js
diff --git a/test/debugger/test-api.js b/test/debugger/test-api.js
index 22dac703194f618840067a32c4fe12a9786c1f4b..2dec3248b329639f787ef83c1c3c95501f3d6933 100644
--- a/test/debugger/test-api.js
+++ b/test/debugger/test-api.js
@@ -677,13 +677,12 @@
};
}
- evaluateOnCallFrame(frame, expr, throw_on_side_effect = false) {
+ evaluateOnCallFrame(frame, expr) {
const frameid = frame.callFrameId;
const {msgid, msg} = this.createMessage(
"Debugger.evaluateOnCallFrame",
{ callFrameId : frameid,
- expression : expr,
- throwOnSideEffect : throw_on_side_effect,
+ expression : expr
});
this.sendMessage(msg);
const reply = this.takeReplyChecked(msgid);
@@ -728,8 +727,7 @@
sourceLine : () => line + 1,
sourceLineText : () => loc.sourceText,
sourcePosition : () => loc.position,
- evaluate : (expr, throw_on_side_effect) =>
- this.evaluateOnCallFrame(frame, expr, throw_on_side_effect),
+ evaluate : (expr) => this.evaluateOnCallFrame(frame, expr),
functionName : () => frame.functionName,
func : () => func,
index : () => index,
« no previous file with comments | « test/debugger/debug/debug-evaluate-no-side-effect-builtins.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698