Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2677183002: [test] Make CHECK_EQ calls in cctest consistent. (Closed)

Created:
3 years, 10 months ago by Franzi
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Make CHECK_EQ calls in cctest consistent. Cleanup CHECK_EQ order and simplify CHECK_EQ(true/false). Cleanup callorder for negative numbers Cleanup callorder order for capital letter constants. Cleanup callorder for test.x checks. BUG= Review-Url: https://codereview.chromium.org/2677183002 Cr-Commit-Position: refs/heads/master@{#42997} Committed: https://chromium.googlesource.com/v8/v8/+/3df821c24efd956cee4c79bbe5cb8efda5f93d81

Patch Set 1 #

Patch Set 2 : Cleanup callorder for negative numbers #

Patch Set 3 : Change order for capital letter constants. #

Patch Set 4 : Cleanup order for test.x checks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -175 lines) Patch
M test/cctest/test-accessors.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 2 3 15 chunks +40 lines, -41 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 2 3 12 chunks +40 lines, -41 lines 0 comments Download
M test/cctest/test-assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-layout.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-dictionary.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-elements-kind.cc View 1 2 26 chunks +34 lines, -34 lines 0 comments Download
M test/cctest/test-flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 8 chunks +30 lines, -30 lines 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (18 generated)
Franzi
PTAL.
3 years, 10 months ago (2017-02-06 15:44:50 UTC) #16
Yang
On 2017/02/06 15:44:50, Franzi wrote: > PTAL. lgtm. thanks for the clean up!
3 years, 10 months ago (2017-02-07 13:51:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677183002/60001
3 years, 10 months ago (2017-02-07 13:55:50 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 14:20:08 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/3df821c24efd956cee4c79bbe5cb8efda5f...

Powered by Google App Engine
This is Rietveld 408576698