test/cctest/test-code-stub-assembler.cc - Issue 2677183002: [test] Make CHECK_EQ calls in cctest consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-code-stub-assembler.cc

Issue 2677183002: [test] Make CHECK_EQ calls in cctest consistent. (Closed)

Patch Set: Cleanup order for test.x checks. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-code-stub-assembler.cc

diff --git a/test/cctest/test-code-stub-assembler.cc b/test/cctest/test-code-stub-assembler.cc

index 2b14804c0391813b00ad11f799a173d00baf4567..e00b0c232a29064c738729ae926bf769bc08f038 100644

--- a/test/cctest/test-code-stub-assembler.cc

+++ b/test/cctest/test-code-stub-assembler.cc

@@ -1579,7 +1579,7 @@ TEST(IsDebugActive) {

CHECK(!code.is_null());

FunctionTester ft(code, kNumParams);

- CHECK_EQ(false, isolate->debug()->is_active());

+ CHECK(!isolate->debug()->is_active());

Handle<Object> result =

ft.Call(isolate->factory()->undefined_value()).ToHandleChecked();

CHECK_EQ(isolate->heap()->false_value(), *result);

« no previous file with comments | « test/cctest/test-code-layout.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »