Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: test/cctest/test-code-layout.cc

Issue 2677183002: [test] Make CHECK_EQ calls in cctest consistent. (Closed)
Patch Set: Cleanup order for test.x checks. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-assembler-x87.cc ('k') | test/cctest/test-code-stub-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-code-layout.cc
diff --git a/test/cctest/test-code-layout.cc b/test/cctest/test-code-layout.cc
index 7e80dd64173b9b2b13c7cf1914cf41a40dc59c3e..c2e109a16656559bbf6c5701a0cd41c15bb33af1 100644
--- a/test/cctest/test-code-layout.cc
+++ b/test/cctest/test-code-layout.cc
@@ -42,7 +42,7 @@ TEST(CodeLayoutWithoutUnwindingInfo) {
CHECK(!code->has_unwinding_info());
CHECK_EQ(code->instruction_size(), buffer_size);
- CHECK_EQ(memcmp(code->instruction_start(), buffer, buffer_size), 0);
+ CHECK_EQ(0, memcmp(code->instruction_start(), buffer, buffer_size));
CHECK_EQ(code->instruction_end() - reinterpret_cast<byte*>(*code),
Code::kHeaderSize + buffer_size - kHeapObjectTag);
}
@@ -79,7 +79,7 @@ TEST(CodeLayoutWithUnwindingInfo) {
CHECK(code->has_unwinding_info());
CHECK_EQ(code->instruction_size(), buffer_size);
- CHECK_EQ(memcmp(code->instruction_start(), buffer, buffer_size), 0);
+ CHECK_EQ(0, memcmp(code->instruction_start(), buffer, buffer_size));
CHECK(IsAligned(code->GetUnwindingInfoSizeOffset(), 8));
CHECK_EQ(code->unwinding_info_size(), unwinding_info_size);
CHECK(
« no previous file with comments | « test/cctest/test-assembler-x87.cc ('k') | test/cctest/test-code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698