Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: test/cctest/test-parsing.cc

Issue 2677183002: [test] Make CHECK_EQ calls in cctest consistent. (Closed)
Patch Set: Cleanup order for test.x checks. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-macro-assembler-mips64.cc ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 5a7809c5862a0aefde1ab7ae76360306b63fc550..b4a82c5369365b97f1209002e123a087c92e8aae 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1189,7 +1189,7 @@ TEST(ScopePositions) {
// Check scope types and positions.
i::Scope* scope = info.literal()->scope();
CHECK(scope->is_script_scope());
- CHECK_EQ(scope->start_position(), 0);
+ CHECK_EQ(0, scope->start_position());
CHECK_EQ(scope->end_position(), kProgramSize);
i::Scope* inner_scope = scope->inner_scope();
@@ -6467,15 +6467,15 @@ TEST(ModuleParsingInternals) {
CHECK_EQ(5u, descriptor->module_requests().size());
for (const auto& elem : descriptor->module_requests()) {
if (elem.first->IsOneByteEqualTo("m.js"))
- CHECK_EQ(elem.second, 0);
+ CHECK_EQ(0, elem.second);
else if (elem.first->IsOneByteEqualTo("n.js"))
- CHECK_EQ(elem.second, 1);
+ CHECK_EQ(1, elem.second);
else if (elem.first->IsOneByteEqualTo("p.js"))
- CHECK_EQ(elem.second, 2);
+ CHECK_EQ(2, elem.second);
else if (elem.first->IsOneByteEqualTo("q.js"))
- CHECK_EQ(elem.second, 3);
+ CHECK_EQ(3, elem.second);
else if (elem.first->IsOneByteEqualTo("bar.js"))
- CHECK_EQ(elem.second, 4);
+ CHECK_EQ(4, elem.second);
else
CHECK(false);
}
« no previous file with comments | « test/cctest/test-macro-assembler-mips64.cc ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698