Convert DelayNode tests to testharness

Convert DelayNode tests to testharness

Manually convert the tests to testharness and new Audit.

BUG=688065
TEST=delaynode-max-default-delay.html,
delaynode-max-nondefault-delay.html, delaynode-maxdelay.html,
delaynode-scheduling.html, delaynode.html

Review-Url: https://codereview.chromium.org/2675823002
Cr-Commit-Position: refs/heads/master@{#448689}
Committed: https://chromium.googlesource.com/chromium/src/+/81a6df48520904f38fef52dd165dc24e5cbf95e4

[Raymond Toy, 2017-02-02 22:07:58]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-02 22:07:58]

PTAL

[hongchan, 2017-02-06 17:20:28]

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html:36:
.then(task.done.bind(task));
task => task.done()

This might be more readable. (from now on)

bind() is a funky way of limiting the scope of |this| variable. We should slowly
move away from it because ES6 new function notation is better in many ways.
Especially for our purpose.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html:37:
.then(task.done.bind(task));;
ditto.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html:17:
task.describe("Basic functionality of DelayNode with a non-default max delay
time")
At least the new code needs to be wrapped at 80 cols.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html:39:
.then(task.done.bind(task));
ditto.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html:49:
.then(task.done.bind(task));
ditto.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html:37:
.then(task.done.bind(task));
ditto.

[Raymond Toy, 2017-02-06 18:41:37]

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html:36:
.then(task.done.bind(task));
On 2017/02/06 17:20:27, hongchan wrote:
> task => task.done()
> 
> This might be more readable. (from now on)
> 
> bind() is a funky way of limiting the scope of |this| variable. We should
slowly
> move away from it because ES6 new function notation is better in many ways.
> Especially for our purpose.

Done.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html:37:
.then(task.done.bind(task));;
On 2017/02/06 17:20:27, hongchan wrote:
> ditto.

Done.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html:17:
task.describe("Basic functionality of DelayNode with a non-default max delay
time")
On 2017/02/06 17:20:27, hongchan wrote:
> At least the new code needs to be wrapped at 80 cols.

Done.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html:39:
.then(task.done.bind(task));
On 2017/02/06 17:20:27, hongchan wrote:
> ditto.

Done.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html:49:
.then(task.done.bind(task));
On 2017/02/06 17:20:28, hongchan wrote:
> ditto.

Done.

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html
(right):

https://codereview.chromium.org/2675823002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html:37:
.then(task.done.bind(task));
On 2017/02/06 17:20:28, hongchan wrote:
> ditto.

Done.

[hongchan, 2017-02-07 18:09:52]

lgtm

[Raymond Toy, 2017-02-07 18:14:12]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-02-07 18:14:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:19:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486491252410360,
"parent_rev": "eeca548902f5508923a683529845f369cc392c6f", "commit_rev":
"81a6df48520904f38fef52dd165dc24e5cbf95e4"}

[commit-bot: I haz the power, 2017-02-07 19:20:33]

Description was changed from

==========
Convert DelayNode tests to testharness

Manually convert the tests to testharness and new Audit.

BUG=688065
TEST=delaynode-max-default-delay.html,
delaynode-max-nondefault-delay.html, delaynode-maxdelay.html,
delaynode-scheduling.html, delaynode.html
==========

to

==========
Convert DelayNode tests to testharness

Manually convert the tests to testharness and new Audit.

BUG=688065
TEST=delaynode-max-default-delay.html,
delaynode-max-nondefault-delay.html, delaynode-maxdelay.html,
delaynode-scheduling.html, delaynode.html

Review-Url: https://codereview.chromium.org/2675823002
Cr-Commit-Position: refs/heads/master@{#448689}
Committed:
https://chromium.googlesource.com/chromium/src/+/81a6df48520904f38fef52dd165d...
==========

[commit-bot: I haz the power, 2017-02-07 19:20:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/81a6df48520904f38fef52dd165d...