third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html - Issue 2675823002: Convert DelayNode tests to testharness

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html

Issue 2675823002: Convert DelayNode tests to testharness (Closed)

Patch Set: Address review comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html

index 278bd431a7b2998f24570f216a1af7299209ab61..fe477bcf105f45f2b2df8ef0d9e630c616348eba 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html

@@ -2,27 +2,19 @@

<html>

<head>

-<script src="../../resources/js-test.js"></script>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

-<script src="../resources/audio-testing.js"></script>

+<script src="../resources/audit.js"></script>

</head>

<body>

-<div id="description"></div>

-<div id="console"></div>

-description("Tests attribute and maximum allowed delay of DelayNode.");

+let audit = Audit.createTaskRunner();

-function runTest() {

- if (window.testRunner) {

- testRunner.dumpAsText();

- testRunner.waitUntilDone();

- }

- window.jsTestIsAsync = true;

+audit.define("test", function (task, should) {

+ task.describe("Tests attribute and maximum allowed delay of DelayNode");

// Create offline audio context.

var context = new OfflineAudioContext(1, sampleRate * renderLengthSeconds, sampleRate);

@@ -32,25 +24,32 @@ function runTest() {

bufferSource.buffer = toneBuffer;

window.context = context;

- shouldThrow("context.createDelay(180)");

- shouldThrow("context.createDelay(0)");

- shouldThrow("context.createDelay(-1)");

- shouldThrow("context.createDelay(NaN)");

+ should(() => context.createDelay(180))

+ .throw();

+ should(() => context.createDelay(0))

+ .throw();

+ should(() => context.createDelay(-1))

+ .throw();

+ should(() => context.createDelay(NaN))

+ .throw();

var delay = context.createDelay(179);

delay.delayTime.value = delayTimeSeconds;

window.delay = delay;

- shouldBeTrue("delay.delayTime.value === 0.5");

+ should(delay.delayTime.value,

+ "delay.delayTime.value = " + delayTimeSeconds)

+ .beEqualTo(delayTimeSeconds);

bufferSource.connect(delay);

delay.connect(context.destination);

bufferSource.start(0);

- context.oncomplete = checkDelayedResult(toneBuffer);

- context.startRendering();

+ context.startRendering()

+ .then(buffer => checkDelayedResult(buffer, toneBuffer, should))

+ .then(() => task.done());

+});

-runTest();

+audit.run();

</script>