Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html

Issue 2675823002: Convert DelayNode tests to testharness (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
index f9c17fb52788f684d951bb8cb1ecd6dbbd6e7934..cafb81ddd2d561d8d21ca5d8a766f74528897363 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
@@ -2,27 +2,20 @@
<html>
<head>
-<script src="../../resources/js-test.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
-<script src="../resources/audio-testing.js"></script>
+<script src="../resources/audit.js"></script>
<script src="../resources/delay-testing.js"></script>
</head>
<body>
-
-<div id="description"></div>
-<div id="console"></div>
-
<script>
-description("Tests basic functionality of DelayNode with a non-default max delay time.");
+let audit = Audit.createTaskRunner();
-function runTest() {
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- }
-
- window.jsTestIsAsync = true;
+audit.define("test", function (task, should) {
+ task.describe(
+ "Basic functionality of DelayNode with a non-default max delay time")
// Create offline audio context.
var context = new OfflineAudioContext(1, sampleRate * renderLengthSeconds, sampleRate);
@@ -42,12 +35,12 @@ function runTest() {
delay.connect(context.destination);
bufferSource.start(0);
- context.oncomplete = checkDelayedResult(toneBuffer);
- context.startRendering();
-}
-
-runTest();
+ context.startRendering()
+ .then(buffer => checkDelayedResult(buffer, toneBuffer, should))
+ .then(() => task.done());
+});
+audit.run();
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698