Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html

Issue 2675823002: Convert DelayNode tests to testharness (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html
index c0589ee87f9b224e8f7c1bc17b2a62f1ac15550b..a9ad29f556784ba83ce332c44574e458da9dea91 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html
@@ -2,28 +2,20 @@
<html>
<head>
-<script src="../../resources/js-test.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
-<script src="../resources/audio-testing.js"></script>
+<script src="../resources/audit.js"></script>
<script src="../resources/delay-testing.js"></script>
</head>
<body>
-
-<div id="description"></div>
-<div id="console"></div>
-
<script>
-description("Tests DelayNode with delay set to default maximum delay.");
+let audit = Audit.createTaskRunner();
+
+audit.define("test", function (task, should) {
+ task.describe("DelayNode with delay set to default maximum delay");
-function runTest() {
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- }
-
- window.jsTestIsAsync = true;
-
// Create offline audio context.
var context = new OfflineAudioContext(1, sampleRate * renderLengthSeconds, sampleRate);
var toneBuffer = createToneBuffer(context, 20, 20 * toneLengthSeconds, sampleRate); // 20Hz tone
@@ -39,11 +31,12 @@ function runTest() {
delay.connect(context.destination);
bufferSource.start(0);
- context.oncomplete = checkDelayedResult(toneBuffer);
- context.startRendering();
-}
+ context.startRendering()
+ .then(buffer => checkDelayedResult(buffer, toneBuffer, should))
+ .then(() => task.done());
+});
-runTest();
+audit.run();
</script>

Powered by Google App Engine
This is Rietveld 408576698