Convert extensions::TabHelper to use the new navigation callbacks.

Convert extensions::TabHelper to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2668003004
Cr-Commit-Position: refs/heads/master@{#447666}
Committed: https://chromium.googlesource.com/chromium/src/+/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9

[jam, 2017-02-01 05:28:16]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-02-01 05:28:25]

Description was changed from

==========
Convert extensions::TabHelper to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert extensions::TabHelper to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-02-01 05:28:25]

jam@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-02-01 05:28:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 05:40:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 05:40:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-02-01 20:44:17]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 20:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 20:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 20:57:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-02-01 21:54:53]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-02-01 21:54:54]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-01 21:55:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 22:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 22:33:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-02-01 22:54:20]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-02-01 22:54:39]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-02-01 22:54:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-02-01 23:18:22]

lgtm

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc
(right):

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc:203:
navigation_handle.reset(); // So that it's destructor doesn't call |tab|.
That's weird - shouldn't this be destroyed first already, since it's allocated
higher on the stack?

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/tab_helper.cc:325: [this,
&navigation_handle](ContentRulesRegistry* registry) {
nit: any reason to capture navigation_handle by reference rather than by value
(since it's a pointer)?

https://codereview.chromium.org/2668003004/diff/60001/extensions/browser/api/...
File extensions/browser/api/declarative_content/content_rules_registry.h
(right):

https://codereview.chromium.org/2668003004/diff/60001/extensions/browser/api/...
extensions/browser/api/declarative_content/content_rules_registry.h:49: //
Applies all content rules given that a tab was just navigated.
nit: while you're here, mind adding something like:
// This corresponds to the notification of the same name in
// content::WebContentsObserver.
?

[commit-bot: I haz the power, 2017-02-01 23:41:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 23:41:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-02-01 23:47:30]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:47:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-01 23:48:50]

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc
(right):

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc:203:
navigation_handle.reset(); // So that it's destructor doesn't call |tab|.
On 2017/02/01 23:18:21, Devlin wrote:
> That's weird - shouldn't this be destroyed first already, since it's allocated
> higher on the stack?

Fixed (my initial attempt was a misreading as you noted and I hastily sent it
for review while verifying!).

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/2668003004/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/tab_helper.cc:325: [this,
&navigation_handle](ContentRulesRegistry* registry) {
On 2017/02/01 23:18:22, Devlin wrote:
> nit: any reason to capture navigation_handle by reference rather than by value
> (since it's a pointer)?

no, you're right this was an oversight. thanks, fixed.

https://codereview.chromium.org/2668003004/diff/60001/extensions/browser/api/...
File extensions/browser/api/declarative_content/content_rules_registry.h
(right):

https://codereview.chromium.org/2668003004/diff/60001/extensions/browser/api/...
extensions/browser/api/declarative_content/content_rules_registry.h:49: //
Applies all content rules given that a tab was just navigated.
On 2017/02/01 23:18:22, Devlin wrote:
> nit: while you're here, mind adding something like:
> // This corresponds to the notification of the same name in
> // content::WebContentsObserver.
> ?

Done.

[jam, 2017-02-02 00:25:29]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-02-02 00:25:34]

The CQ bit was checked by jam@chromium.org

[jam, 2017-02-02 00:25:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2668003004/#ps80001
(title: "update")

[commit-bot: I haz the power, 2017-02-02 00:25:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 01:04:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485995134165300,
"parent_rev": "a5448faaa978030249a1e99619418433a42d4da6", "commit_rev":
"f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9"}

[commit-bot: I haz the power, 2017-02-02 01:08:58]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485995134165300,
"parent_rev": "a5448faaa978030249a1e99619418433a42d4da6", "commit_rev":
"f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9"}

[commit-bot: I haz the power, 2017-02-02 01:09:24]

Description was changed from

==========
Convert extensions::TabHelper to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert extensions::TabHelper to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2668003004
Cr-Commit-Position: refs/heads/master@{#447666}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1c7f0cc75e1443cb6f5d728e61d...
==========

[commit-bot: I haz the power, 2017-02-02 01:09:26]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f1c7f0cc75e1443cb6f5d728e61d...