chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc - Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc

Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks. (Closed)

Patch Set: update Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h ('k') | chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc

diff --git a/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc b/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc

index e6271fe09579f57fcc780f4f79e13db4ea7d672e..ef185b0aa3f40c601b8ed078f21ee4231a74a9e4 100644

--- a/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc

+++ b/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc

@@ -192,8 +192,7 @@ void DeclarativeContentPageUrlConditionTracker::TrackForWebContents(

void DeclarativeContentPageUrlConditionTracker::OnWebContentsNavigation(

content::WebContents* contents,

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) {

+ content::NavigationHandle* navigation_handle) {

DCHECK(base::ContainsKey(per_web_contents_tracker_, contents));

per_web_contents_tracker_[contents]->UpdateMatchesForCurrentUrl(true);

}