chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc - Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks. (Closed)

Patch Set: update Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h ('k') | chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

index c5b2f3d705d768d6b08baeb5b26b6e579418a034..45b6c3b4a43ad5a948ce9df6d1f7459f284ab812 100644

--- a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc

@@ -132,15 +132,14 @@ void ChromeContentRulesRegistry::MonitorWebContentsForRuleEvaluation(

evaluator->TrackForWebContents(contents);

}

-void ChromeContentRulesRegistry::DidNavigateMainFrame(

+void ChromeContentRulesRegistry::DidFinishNavigation(

content::WebContents* contents,

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) {

+ content::NavigationHandle* navigation_handle) {

if (base::ContainsKey(active_rules_, contents)) {

EvaluationScope evaluation_scope(this);

for (const std::unique_ptr<ContentPredicateEvaluator>& evaluator :

evaluators_)

- evaluator->OnWebContentsNavigation(contents, details, params);

+ evaluator->OnWebContentsNavigation(contents, navigation_handle);

}