chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h - Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h

Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks. (Closed)

Patch Set: update Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker_unittest.cc ('k') | chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h

diff --git a/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h b/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h

index e8226bdb1be1847aaf98ba1432a4c3c0943f67c6..82fe962f0205e1833d74073ff0b385dcf4262b27 100644

--- a/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h

+++ b/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h

@@ -20,12 +20,6 @@ namespace base {

class Value;

}

-namespace content {

-struct FrameNavigateParams;

-struct LoadCommittedDetails;

-class WebContents;

namespace extensions {

class Extension;

@@ -85,8 +79,7 @@ class DeclarativeContentPageUrlConditionTracker

void TrackForWebContents(content::WebContents* contents) override;

void OnWebContentsNavigation(

content::WebContents* contents,

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) override;

+ content::NavigationHandle* navigation_handle) override;

bool EvaluatePredicate(const ContentPredicate* predicate,

content::WebContents* tab) const override;