Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: chrome/browser/extensions/tab_helper.h

Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks. (Closed)
Patch Set: update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/tab_helper.h
diff --git a/chrome/browser/extensions/tab_helper.h b/chrome/browser/extensions/tab_helper.h
index 30794850108c51910b8536a0f4362d13c3437f9a..2ec39837ebb422ee062934a71da8cb2a2393487a 100644
--- a/chrome/browser/extensions/tab_helper.h
+++ b/chrome/browser/extensions/tab_helper.h
@@ -30,11 +30,6 @@
#include "extensions/common/stack_frame.h"
#include "third_party/skia/include/core/SkBitmap.h"
-namespace content {
-struct LoadCommittedDetails;
-class RenderFrameHost;
-}
-
namespace gfx {
class Image;
}
@@ -149,9 +144,8 @@ class TabHelper : public content::WebContentsObserver,
// content::WebContentsObserver overrides.
void RenderFrameCreated(content::RenderFrameHost* host) override;
- void DidNavigateMainFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
bool OnMessageReceived(const IPC::Message& message) override;
bool OnMessageReceived(const IPC::Message& message,
content::RenderFrameHost* render_frame_host) override;

Powered by Google App Engine
This is Rietveld 408576698