Move two utility functions from ash/screen_util.h to ui/wm/core/coordinate_conversion.h

Move two utility functions from ash/screen_util.h to ui/wm/core/coordinate_conversion.h

|ash::ScreenUtil::ConvertRectToScreen| and
|ash::ScreenUtil::ConvertRectFromScreen| are moved.

BUG=624521
TEST=Added an unit test.

Review-Url: https://codereview.chromium.org/2660873002
Cr-Commit-Position: refs/heads/master@{#452450}
Committed: https://chromium.googlesource.com/chromium/src/+/698af19e9bad67813349d7a89174d140d624075f

[yhanada, 2017-01-30 12:24:44]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 12:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-01-30 12:35:01]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 12:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-01-30 12:38:43]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 12:38:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-01-30 13:03:28]

yhanada@chromium.org changed reviewers:
+ oshima@chromium.org, sadrul@chromium.org, sky@chromium.org

[yhanada, 2017-01-30 13:03:29]

PTAL. Thanks!

[commit-bot: I haz the power, 2017-01-30 13:52:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 13:52:16]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-01-30 19:16:14]

lgtm with nits

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
File ui/wm/core/coordinate_conversion_unittest.cc (right):

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion_unittest.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
nit: 2017

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion_unittest.cc:7: #include <memory>
is this necessary?

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion_unittest.cc:10: #include
"base/memory/ptr_util.h"
and these?

[sadrul, 2017-01-30 19:46:11]

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
File ui/wm/core/coordinate_conversion.h (right):

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion.h:34: const gfx::Rect& rect);
To be consistent with the fns above, would it make sense to change the
signature:
  void ConvertRectToScreen(const aura::Window* window,
                           gfx::Rect* rect);

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion.h:39: const gfx::Rect& rect);
ditto

[yhanada, 2017-01-31 06:33:29]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 06:33:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-01-31 06:34:34]

Thank you for reviewing. Please take another look.

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
File ui/wm/core/coordinate_conversion.h (right):

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion.h:34: const gfx::Rect& rect);
On 2017/01/30 19:46:09, sadrul wrote:
> To be consistent with the fns above, would it make sense to change the
> signature:
>   void ConvertRectToScreen(const aura::Window* window,
>                            gfx::Rect* rect);

Changed to that.

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion.h:39: const gfx::Rect& rect);
On 2017/01/30 19:46:09, sadrul wrote:
> ditto

Done.

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
File ui/wm/core/coordinate_conversion_unittest.cc (right):

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion_unittest.cc:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2017/01/30 19:16:14, oshima wrote:
> nit: 2017

Done.

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion_unittest.cc:7: #include <memory>
On 2017/01/30 19:16:14, oshima wrote:
> is this necessary?

Done.

https://codereview.chromium.org/2660873002/diff/60001/ui/wm/core/coordinate_c...
ui/wm/core/coordinate_conversion_unittest.cc:10: #include
"base/memory/ptr_util.h"
On 2017/01/30 19:16:14, oshima wrote:
> and these?

Done.

[commit-bot: I haz the power, 2017-01-31 08:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 08:11:15]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-01-31 16:58:12]

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
File ui/wm/core/coordinate_conversion.cc (right):

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
ui/wm/core/coordinate_conversion.cc:33: rect->set_origin(point);
It is possible for the window to be rotated/scaled etc., right? In that case,
you can't just change the origin, you also need to update the size.

[yhanada, 2017-02-01 05:27:40]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 05:27:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 06:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 06:24:48]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-02-01 06:39:27]

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
File ui/wm/core/coordinate_conversion.cc (right):

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
ui/wm/core/coordinate_conversion.cc:33: rect->set_origin(point);
On 2017/01/31 16:58:12, sadrul wrote:
> It is possible for the window to be rotated/scaled etc., right? In that case,
> you can't just change the origin, you also need to update the size.

Done.

[oshima, 2017-02-01 18:50:56]

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
File ui/wm/core/coordinate_conversion.cc (right):

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
ui/wm/core/coordinate_conversion.cc:33: rect->set_origin(point);
On 2017/01/31 16:58:12, sadrul wrote:
> It is possible for the window to be rotated/scaled etc., right? In that case,
> you can't just change the origin, you also need to update the size.

It is not possible to convert rect to rect over arbitrary transform, because tbe
result may not longer be rectangular after transformed.

This is at least consistent with what aura window does:

https://cs.chromium.org/chromium/src/ui/aura/window.cc?rcl=5e61cddf30c3bd3490...

I believe this assumes that it's not used for such case, and probably
won't cause any issue though, although you may want to keep consistent.
(or change aura window).

[sadrul, 2017-02-02 17:33:17]

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
File ui/wm/core/coordinate_conversion.cc (right):

https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
ui/wm/core/coordinate_conversion.cc:33: rect->set_origin(point);
On 2017/02/01 18:50:56, oshima wrote:
> On 2017/01/31 16:58:12, sadrul wrote:
> > It is possible for the window to be rotated/scaled etc., right? In that
case,
> > you can't just change the origin, you also need to update the size.
> 
> It is not possible to convert rect to rect over arbitrary transform, because
tbe
> result may not longer be rectangular after transformed.
> 
> This is at least consistent with what aura window does:
> 
>
https://cs.chromium.org/chromium/src/ui/aura/window.cc?rcl=5e61cddf30c3bd3490...
> 
> I believe this assumes that it's not used for such case, and probably
> won't cause any issue though, although you may want to keep consistent.
> (or change aura window).
> 
> 

We should fix aura window. Even the new code isn't entirely correct (but is
better than this). We should get the transform and transform the entire rect
(using gfx::Transform::TransformRect, like we do in views:
https://cs.chromium.org/chromium/src/ui/views/view.cc?type=cs&sq=package:chro...
)

[oshima, 2017-02-02 18:12:57]

On 2017/02/02 17:33:17, sadrul wrote:
>
https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
> File ui/wm/core/coordinate_conversion.cc (right):
> 
>
https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
> ui/wm/core/coordinate_conversion.cc:33: rect->set_origin(point);
> On 2017/02/01 18:50:56, oshima wrote:
> > On 2017/01/31 16:58:12, sadrul wrote:
> > > It is possible for the window to be rotated/scaled etc., right? In that
> case,
> > > you can't just change the origin, you also need to update the size.
> > 
> > It is not possible to convert rect to rect over arbitrary transform, because
> tbe
> > result may not longer be rectangular after transformed.
> > 
> > This is at least consistent with what aura window does:
> > 
> >
>
https://cs.chromium.org/chromium/src/ui/aura/window.cc?rcl=5e61cddf30c3bd3490...
> > 
> > I believe this assumes that it's not used for such case, and probably
> > won't cause any issue though, although you may want to keep consistent.
> > (or change aura window).
> > 
> > 
> 
> We should fix aura window. Even the new code isn't entirely correct (but is
> better than this).

I agree that it should be consistent.

> We should get the transform and transform the entire rect
> (using gfx::Transform::TransformRect, like we do in views:
>
https://cs.chromium.org/chromium/src/ui/views/view.cc?type=cs&sq=package:chro...
> )

I think that's fine.

Just one caveat though. Whether or not this will do correct thing depends on
what client want to do.
Say if you want to compute the bounds that you want to set on window, it can
give you wrong bounds.
We had a bug that we're saving the transformed bounds as a restore bounds :)

[yhanada, 2017-02-03 07:35:45]

On 2017/02/02 18:12:57, oshima wrote:
> On 2017/02/02 17:33:17, sadrul wrote:
> >
>
https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
> > File ui/wm/core/coordinate_conversion.cc (right):
> > 
> >
>
https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
> > ui/wm/core/coordinate_conversion.cc:33: rect->set_origin(point);
> > On 2017/02/01 18:50:56, oshima wrote:
> > > On 2017/01/31 16:58:12, sadrul wrote:
> > > > It is possible for the window to be rotated/scaled etc., right? In that
> > case,
> > > > you can't just change the origin, you also need to update the size.
> > > 
> > > It is not possible to convert rect to rect over arbitrary transform,
because
> > tbe
> > > result may not longer be rectangular after transformed.
> > > 
> > > This is at least consistent with what aura window does:
> > > 
> > >
> >
>
https://cs.chromium.org/chromium/src/ui/aura/window.cc?rcl=5e61cddf30c3bd3490...
> > > 
> > > I believe this assumes that it's not used for such case, and probably
> > > won't cause any issue though, although you may want to keep consistent.
> > > (or change aura window).
> > > 
> > > 
> > 
> > We should fix aura window. Even the new code isn't entirely correct (but is
> > better than this).
> 
> I agree that it should be consistent.
> 
> > We should get the transform and transform the entire rect
> > (using gfx::Transform::TransformRect, like we do in views:
> >
>
https://cs.chromium.org/chromium/src/ui/views/view.cc?type=cs&sq=package:chro...
> > )
> 
> I think that's fine.
> 
> Just one caveat though. Whether or not this will do correct thing depends on
> what client want to do.
> Say if you want to compute the bounds that you want to set on window, it can
> give you wrong bounds.
> We had a bug that we're saving the transformed bounds as a restore bounds :)

Thank you for the input!
Does it make sense to create two separate method, one returns transformed rect
and another doesn't use transform, to avoid a bug like that?
I want to use these converting method for calculating a restore bounds in the
following change. Does the caller have to do reverse transformation if there is
only a method that returns transformed rect?

[oshima, 2017-02-03 16:47:20]

On 2017/02/03 07:35:45, yhanada wrote:
> On 2017/02/02 18:12:57, oshima wrote:
> > On 2017/02/02 17:33:17, sadrul wrote:
> > >
> >
>
https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
> > > File ui/wm/core/coordinate_conversion.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2660873002/diff/100001/ui/wm/core/coordinate_...
> > > ui/wm/core/coordinate_conversion.cc:33: rect->set_origin(point);
> > > On 2017/02/01 18:50:56, oshima wrote:
> > > > On 2017/01/31 16:58:12, sadrul wrote:
> > > > > It is possible for the window to be rotated/scaled etc., right? In
that
> > > case,
> > > > > you can't just change the origin, you also need to update the size.
> > > > 
> > > > It is not possible to convert rect to rect over arbitrary transform,
> because
> > > tbe
> > > > result may not longer be rectangular after transformed.
> > > > 
> > > > This is at least consistent with what aura window does:
> > > > 
> > > >
> > >
> >
>
https://cs.chromium.org/chromium/src/ui/aura/window.cc?rcl=5e61cddf30c3bd3490...
> > > > 
> > > > I believe this assumes that it's not used for such case, and probably
> > > > won't cause any issue though, although you may want to keep consistent.
> > > > (or change aura window).
> > > > 
> > > > 
> > > 
> > > We should fix aura window. Even the new code isn't entirely correct (but
is
> > > better than this).
> > 
> > I agree that it should be consistent.
> > 
> > > We should get the transform and transform the entire rect
> > > (using gfx::Transform::TransformRect, like we do in views:
> > >
> >
>
https://cs.chromium.org/chromium/src/ui/views/view.cc?type=cs&sq=package:chro...
> > > )
> > 
> > I think that's fine.
> > 
> > Just one caveat though. Whether or not this will do correct thing depends on
> > what client want to do.
> > Say if you want to compute the bounds that you want to set on window, it can
> > give you wrong bounds.
> > We had a bug that we're saving the transformed bounds as a restore bounds :)
> 
> Thank you for the input!
> Does it make sense to create two separate method, one returns transformed rect
> and another doesn't use transform, to avoid a bug like that?
> I want to use these converting method for calculating a restore bounds in the
> following change. Does the caller have to do reverse transformation if there
is
> only a method that returns transformed rect?

We don't know if it's necessary yet, so let's keep it simple.

[yhanada, 2017-02-14 09:20:55]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 09:21:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 10:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 10:16:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhanada, 2017-02-16 06:29:57]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 06:30:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-02-16 06:34:02]

sadrul@: Could you take another look?

Some users of this method expects non-transformed result from this method, so
I'd like to change the method later to use Transform to minimize this change.

[commit-bot: I haz the power, 2017-02-16 07:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 07:51:13]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yhanada, 2017-02-21 08:52:29]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 08:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 10:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 10:35:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yhanada1, 2017-02-21 10:40:04]

The CQ bit was checked by yhanada@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 10:40:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 11:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 11:23:58]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-02-21 19:23:56]

lgtm

[yhanada, 2017-02-22 08:28:42]

yhanada@chromium.org changed reviewers:
- yhanada@google.com

[yhanada, 2017-02-22 08:28:43]

Thank you for reviewing!

[yhanada, 2017-02-22 08:28:50]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-02-22 08:28:51]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2660873002/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-22 08:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 08:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 08:39:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yhanada, 2017-02-22 08:41:09]

yhanada@chromium.org changed reviewers:
+ benwells@chromium.org

[yhanada, 2017-02-22 08:41:10]

Hi benwells@, PTAL at
	chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc as the
owner. Thanks!

[yhanada, 2017-02-22 11:38:12]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 11:38:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 13:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 13:45:41]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-02-23 04:56:09]

lgtm

[yhanada, 2017-02-23 04:56:50]

On 2017/02/23 04:56:09, benwells wrote:
> lgtm

Thanks!

[yhanada, 2017-02-23 04:57:00]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-02-23 04:57:01]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2660873002/#ps220001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-23 04:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 05:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 05:03:30]

Failed to apply patch for ash/common/wm/dock/docked_window_layout_manager.cc:
While running git apply --index -p1;
  error: patch failed: ash/common/wm/dock/docked_window_layout_manager.cc:20
  error: ash/common/wm/dock/docked_window_layout_manager.cc: patch does not
apply

Patch:       ash/common/wm/dock/docked_window_layout_manager.cc
Index: ash/common/wm/dock/docked_window_layout_manager.cc
diff --git a/ash/common/wm/dock/docked_window_layout_manager.cc
b/ash/common/wm/dock/docked_window_layout_manager.cc
index
93bea20ca478d4eea6c55839892dc723a2f77dac..70a562f36d049600f4efed5b8ac8674857592c62
100644
--- a/ash/common/wm/dock/docked_window_layout_manager.cc
+++ b/ash/common/wm/dock/docked_window_layout_manager.cc
@@ -20,7 +20,6 @@
 #include "ash/common/wm_window.h"
 #include "ash/public/cpp/shell_window_ids.h"
 #include "ash/root_window_controller.h"
-#include "ash/screen_util.h"
 #include "ash/wm/window_state_aura.h"
 #include "base/auto_reset.h"
 #include "base/metrics/histogram_macros.h"
@@ -31,6 +30,7 @@
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/views/background.h"
+#include "ui/wm/core/coordinate_conversion.h"
 #include "ui/wm/core/window_animations.h"
 
 namespace ash {
@@ -333,8 +333,8 @@ class DockedWindowLayoutManager::ShelfWindowObserver
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
                              const gfx::Rect& new_bounds) override {
-    shelf_bounds_in_screen_ =
-        ScreenUtil::ConvertRectToScreen(window->parent(), new_bounds);
+    shelf_bounds_in_screen_ = new_bounds;
+    ::wm::ConvertRectToScreen(window->parent(), &shelf_bounds_in_screen_);
 
     // When the shelf is auto-hidden, it has an invisible height of 3px used
     // as a hit region which is specific to Chrome OS MD (for non-MD, the 3

[yhanada, 2017-02-23 09:15:40]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-02-23 09:15:41]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
benwells@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2660873002/#ps240001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-23 09:15:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 10:57:11]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1487841340680020,
"parent_rev": "233d5951645e51d856784682bd5c1b32b2f60f81", "commit_rev":
"698af19e9bad67813349d7a89174d140d624075f"}

[commit-bot: I haz the power, 2017-02-23 10:57:46]

Description was changed from

==========
Move two utility functions from ash/screen_util.h to
ui/wm/core/coordinate_conversion.h

|ash::ScreenUtil::ConvertRectToScreen| and
|ash::ScreenUtil::ConvertRectFromScreen| are moved.

BUG=624521
TEST=Added an unit test.
==========

to

==========
Move two utility functions from ash/screen_util.h to
ui/wm/core/coordinate_conversion.h

|ash::ScreenUtil::ConvertRectToScreen| and
|ash::ScreenUtil::ConvertRectFromScreen| are moved.

BUG=624521
TEST=Added an unit test.

Review-Url: https://codereview.chromium.org/2660873002
Cr-Commit-Position: refs/heads/master@{#452450}
Committed:
https://chromium.googlesource.com/chromium/src/+/698af19e9bad67813349d7a89174...
==========

[commit-bot: I haz the power, 2017-02-23 10:57:48]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/698af19e9bad67813349d7a89174...