Move two utility functions from ash/screen_util.h to ui/wm/core/coordinate_conversion.h

ui/wm/core/coordinate_conversion.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/wm/core/coordinate_conversion.h"
 
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/gfx/geometry/point.h"
+#include "ui/gfx/geometry/rect.h"
 
 namespace wm {
 
 void ConvertPointToScreen(const aura::Window* window, gfx::Point* point) {
   DCHECK(window);
   DCHECK(window->GetRootWindow());
   DCHECK(aura::client::GetScreenPositionClient(window->GetRootWindow()));
   aura::client::GetScreenPositionClient(window->GetRootWindow())->
       ConvertPointToScreen(window, point);
 }
 
 void ConvertPointFromScreen(const aura::Window* window,
                             gfx::Point* point_in_screen) {
   DCHECK(window);
   DCHECK(window->GetRootWindow());
   DCHECK(aura::client::GetScreenPositionClient(window->GetRootWindow()));
   aura::client::GetScreenPositionClient(window->GetRootWindow())->
       ConvertPointFromScreen(window, point_in_screen);
 }
 
+void ConvertRectToScreen(const aura::Window* window, gfx::Rect* rect) {
+  gfx::Point point = rect->origin();
+  ConvertPointToScreen(window, &point);
+  rect->set_origin(point);

[sadrul, 2017/01/31 16:58:12]

It is possible for the window to be rotated/scaled etc., right? In that case,
you can't just change the origin, you also need to update the size.

[yhanada, 2017/02/01 06:39:27]

Done.

[oshima, 2017/02/01 18:50:56]

It is not possible to convert rect to rect over arbitrary transform, because tbe
result may not longer be rectangular after transformed.

This is at least consistent with what aura window does:

https://cs.chromium.org/chromium/src/ui/aura/window.cc?rcl=5e61cddf30c3bd3490...

I believe this assumes that it's not used for such case, and probably
won't cause any issue though, although you may want to keep consistent.
(or change aura window).

[sadrul, 2017/02/02 17:33:17]

We should fix aura window. Even the new code isn't entirely correct (but is
better than this). We should get the transform and transform the entire rect
(using gfx::Transform::TransformRect, like we do in views:
https://cs.chromium.org/chromium/src/ui/views/view.cc?type=cs&sq=package:chro...
)

+}
+
+void ConvertRectFromScreen(const aura::Window* window,
+                           gfx::Rect* rect_in_screen) {
+  gfx::Point point = rect_in_screen->origin();
+  ConvertPointFromScreen(window, &point);
+  rect_in_screen->set_origin(point);
+}
+
 }  // namespace wm